From: akepner@sgi.com
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Jes Sorensen <jes@sgi.com>, David Miller <davem@davemloft.net>,
Roland Dreier <rdreier@cisco.com>,
linux-kernel@vger.kernel.org, jejb <james.bottomley@steeleye.com>
Subject: Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface
Date: Thu, 27 Sep 2007 17:20:19 -0700 [thread overview]
Message-ID: <20070928002019.GK30013@sgi.com> (raw)
In-Reply-To: <20070925221333.bb722dc4.randy.dunlap@oracle.com>
On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote:
> On Tue, 25 Sep 2007 17:00:57 -0700 akepner@sgi.com wrote:
> ......
> 1. Function signature should be on one line if possible (and it is).
> Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
> Well, it's undesirable, so please don't propagate it.
>
> 2. No parens on return: it's not a function.
>
> static inline int dma_flags_set_dmaflush(int dir)
> {
> return dir;
> }
>
>
> Similar comments for patch 2/4: sn-ia64.
>
Both fixed in next version. Thanks, Randy.
--
Arthur
prev parent reply other threads:[~2007-09-28 0:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 0:00 [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface akepner
2007-09-26 5:13 ` Randy Dunlap
2007-09-28 0:20 ` akepner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928002019.GK30013@sgi.com \
--to=akepner@sgi.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=james.bottomley@steeleye.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.