From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1Ib4Y7-00055s-6O for user-mode-linux-devel@lists.sourceforge.net; Thu, 27 Sep 2007 18:21:47 -0700 Received: from saraswathi.solana.com ([198.99.130.12]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1Ib4Y6-0007mT-Ml for user-mode-linux-devel@lists.sourceforge.net; Thu, 27 Sep 2007 18:21:47 -0700 Date: Thu, 27 Sep 2007 21:21:32 -0400 From: Jeff Dike Message-ID: <20070928012132.GA10302@c2.user-mode-linux.org> References: <20070927170126.GA6542@c2.user-mode-linux.org> <20070927165340.fd5dc2d0.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <20070927165340.fd5dc2d0.akpm@linux-foundation.org> Subject: Re: [uml-devel] [PATCH] UML - Correctly handle skb allocation failures List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Andrew Morton Cc: linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net On Thu, Sep 27, 2007 at 04:53:40PM -0700, Andrew Morton wrote: > Still wanna know why it is safe for uml_net_rx to be playing with > drop_skb when update_drop_skb() could be concurrently reallocating > and freeing it. Ah, yes, I missed that point in the horror of my botch last night. I'll add irqsave/irqrestore to the locking - keep this patch, and I'll send in a fix. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760961AbXI1BV4 (ORCPT ); Thu, 27 Sep 2007 21:21:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757007AbXI1BVt (ORCPT ); Thu, 27 Sep 2007 21:21:49 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:37248 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752889AbXI1BVs (ORCPT ); Thu, 27 Sep 2007 21:21:48 -0400 Date: Thu, 27 Sep 2007 21:21:32 -0400 From: Jeff Dike To: Andrew Morton Cc: linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [PATCH] UML - Correctly handle skb allocation failures Message-ID: <20070928012132.GA10302@c2.user-mode-linux.org> References: <20070927170126.GA6542@c2.user-mode-linux.org> <20070927165340.fd5dc2d0.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070927165340.fd5dc2d0.akpm@linux-foundation.org> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 27, 2007 at 04:53:40PM -0700, Andrew Morton wrote: > Still wanna know why it is safe for uml_net_rx to be playing with > drop_skb when update_drop_skb() could be concurrently reallocating > and freeing it. Ah, yes, I missed that point in the horror of my botch last night. I'll add irqsave/irqrestore to the locking - keep this patch, and I'll send in a fix. Jeff -- Work email - jdike at linux dot intel dot com