From: WANG Cong <xiyou.wangcong@gmail.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Andy Whitcroft <apw@shadowen.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.10
Date: Fri, 28 Sep 2007 19:03:10 +0800 [thread overview]
Message-ID: <20070928110310.GF2443@hacking> (raw)
In-Reply-To: <200709281246.45546.borntraeger@de.ibm.com>
On Fri, Sep 28, 2007 at 12:46:45PM +0200, Christian Borntraeger wrote:
>Am Freitag, 28. September 2007 schrieb Andy Whitcroft:
>> > And this is not about any particular false positive. I dont mind an
>> > "advanced mode" non-default opt-in option for the script, if someone is
>> > interested in borderline or hard to judge warnings too, but these
>> > default false positives are _lethal_ for a tool like this. (and i made
>> > this point before.) This is a _fundamental_ thing, and i'm still not
>> > sure whether you accept and understand that point. This is very basic
>> > and very important, and this isnt the first (or second) time i raised
>> > this.
>>
>> You are striving for a level of perfection that is simply not achieveable.
>
>I dont think Ingo is looking for perfection. Its about a different
>optimization goals.
>
>Let me put it this way:
>
>checkpatch in advanced mode:
>- I want to be able to see as many possible problems (this is the optimization
>goal)
>- I accept that I get false positives
>- not useful for git and mail traffic
>
>checkpatch in safe mode:
>- I never want a false positive (different optimization goal!)
>- I accept that I will miss several real bugs because several tricky tests are
>disabled
>- useful for git and mail traffic
>
Maybe checkpatch.pl needs an option '-W' to turn on/off those vexed "noise".
(It seems that 'q|quiet' doesn't do as much as what it hints.)
;-)
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-09-28 11:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 15:00 [PATCH] update checkpatch.pl to version 0.10 Andy Whitcroft
2007-09-28 8:40 ` Ingo Molnar
2007-09-28 9:01 ` Andrew Morton
2007-09-28 9:22 ` Andy Whitcroft
2007-09-28 9:39 ` Ingo Molnar
2007-09-28 10:00 ` Andy Whitcroft
2007-09-28 10:46 ` Christian Borntraeger
2007-09-28 11:03 ` WANG Cong [this message]
2007-09-28 14:19 ` Jan Engelhardt
2007-09-28 16:57 ` Randy Dunlap
2007-09-28 10:49 ` Ingo Molnar
2007-09-28 13:21 ` Andy Whitcroft
2007-09-28 13:37 ` Pekka Enberg
2007-09-28 14:02 ` Andy Whitcroft
2007-09-28 15:50 ` Joel Schopp
2007-09-28 17:26 ` Randy Dunlap
2007-09-28 17:46 ` Andrew Morton
2007-09-29 9:22 ` Andy Whitcroft
2007-10-05 5:56 ` Ingo Molnar
2007-09-28 16:51 ` Sam Ravnborg
2007-09-28 9:44 ` Ingo Molnar
2007-09-28 9:52 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928110310.GF2443@hacking \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=borntraeger@de.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.