All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Valdis.Kletnieks@vt.edu
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Erez Zadok <ezk@cs.sunysb.edu>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 0/3 coding standards documentation/code updates
Date: Sun, 30 Sep 2007 04:27:24 +0100	[thread overview]
Message-ID: <20070930032724.GY8181@ftp.linux.org.uk> (raw)
In-Reply-To: <18163.1191119041@turing-police.cc.vt.edu>

On Sat, Sep 29, 2007 at 10:24:01PM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Sat, 29 Sep 2007 11:18:05 PDT, Linus Torvalds said:
> 
> > "CodingStyle" should be about the big issues, not about details. Yes, 
> > we've messed that up over the years, but let's not continue that.
> > 
> > In other words, I'd suggest *removing* lines from CodingStyle, not adding 
> > them. The file has already gone from a "good general principles" to "lots 
> > of stupid details". Let's not make it worse.
> 
> I think there needs to be a "sense of fairness" attached here - CodingStyle
> should cover all the stuff maintainers/reviewers are allowed to whinge about.
> Otherwise, we get maintainers whinging about undocumented style rules, and
> we get code submitters who are unhappy because they have no real way to tell
> if their code really *is* stylistically lacking, or if they just have a
> jerk maintainer who wants to keep their code out-of-tree for political
> reasons.

... and no matter how many rules you put down, it's still possible to
write a code that will be awful stylistically while adhering to all of
them.  Religiously.

IOW, it's not going to eliminate that kind of fights.

  parent reply	other threads:[~2007-09-30  3:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 21:31 [PATCH] 0/3 coding standards documentation/code updates Erez Zadok
2007-09-28 21:32 ` [PATCH 1/3] CodingStyle updates Erez Zadok
2007-09-28 21:46   ` Randy Dunlap
2007-09-29 14:43   ` Shawn Bohrer
2007-09-29 15:59   ` Scott Preece
2007-09-29 18:01   ` Randy Dunlap
2007-09-29 18:29     ` Sam Ravnborg
2007-09-29 20:21       ` [OT] kbuild syntax extension for ccflags and asflags (was: [PATCH 1/3] CodingStyle updates) Ingo Oeser
2007-09-29 20:24         ` Sam Ravnborg
2007-09-28 21:32 ` [PATCH 2/3] Update usage string for checkpatch.pl Erez Zadok
2007-09-28 21:32 ` [PATCH 3/3] New script to check coding-style compliance on multiple regular files Erez Zadok
2007-09-29 10:10   ` Sam Ravnborg
2007-09-29 18:18 ` [PATCH] 0/3 coding standards documentation/code updates Linus Torvalds
2007-09-29 19:56   ` J. Bruce Fields
2007-09-29 20:14     ` Randy Dunlap
2007-09-30  2:06     ` Theodore Tso
2007-09-30  3:28       ` Erez Zadok
2007-09-29 21:56   ` Robert P. J. Day
2007-09-30  0:23   ` Erez Zadok
2007-09-30  0:49     ` Linus Torvalds
2007-09-30  4:01       ` Erez Zadok
2007-09-30 17:40         ` Mark Lord
2007-09-30 17:59           ` Randy Dunlap
2007-09-30  2:24   ` Valdis.Kletnieks
2007-09-30  3:00     ` Linus Torvalds
2007-09-30  3:29       ` Valdis.Kletnieks
2007-09-30  3:35         ` Linus Torvalds
2007-09-30 17:57         ` Theodore Tso
2007-09-30  3:27     ` Al Viro [this message]
2007-09-30  3:39       ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070930032724.GY8181@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=ezk@cs.sunysb.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.