All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [patch] MTD: fix cfi_interleave() build errors
Date: Mon, 1 Oct 2007 07:01:45 +0200	[thread overview]
Message-ID: <20071001050145.GA12925@elte.hu> (raw)
In-Reply-To: <20071001045037.GA10564@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> FYI, the attached .config fails with the build errors below. Kernel is 
> latest 2.6.23-git. Found via make randconfig.

the quick fix below resolves these build failures. (i guess it might be 
cleaner/safer to solve this via excluding this .config combination via 
Kconfig rules, but that looks too involved for now.)

	Ingo

---------------->
Subject: MTD: fix cfi_interleave() build errors
From: Ingo Molnar <mingo@elte.hu>

if the .config specifies no cfi_interleave() then generate a
run-time bug. This makes 'make randconfig' build tests work again.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/linux/mtd/cfi.h |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux/include/linux/mtd/cfi.h
===================================================================
--- linux.orig/include/linux/mtd/cfi.h
+++ linux/include/linux/mtd/cfi.h
@@ -57,6 +57,10 @@
 #define cfi_interleave_is_8(cfi) (0)
 #endif
 
+#ifndef cfi_interleave
+# define cfi_interleave(cfi) ({ BUG_ON(1); 0; })
+#endif
+
 static inline int cfi_interleave_supported(int i)
 {
 	switch (i) {

  reply	other threads:[~2007-10-01  5:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-01  4:50 [build bug] MTD build error, v2.6.23-rc8-git4 Ingo Molnar
2007-10-01  5:01 ` Ingo Molnar [this message]
2007-10-01  6:54   ` [patch] MTD: fix cfi_interleave() build errors David Woodhouse
2007-10-01  7:14     ` Ingo Molnar
2007-10-01  7:21       ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071001050145.GA12925@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.