All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Hade <garyhade@us.ibm.com>
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: pcihpd-discuss@lists.sourceforge.net, linux-acpi@vger.kernel.org,
	gregkh@suse.de
Subject: Re: [Pcihpd-discuss] what is writing to /sys/bus/pci/slot/<slot_no>/power really supposed to do?
Date: Mon, 1 Oct 2007 10:43:41 -0700	[thread overview]
Message-ID: <20071001174340.GA10858@us.ibm.com> (raw)
In-Reply-To: <20071001100858.06919a1e.kristen.c.accardi@intel.com>

On Mon, Oct 01, 2007 at 10:08:58AM -0700, Kristen Carlson Accardi wrote:
> Hi,
> I notice in acpiphp that the code path for powering down the slot
> via sysfs does not execute the _EJ0 method, but instead simply
> looks for _PS3 and of couse disables all the bridges and devices.  
> I suppose this could be valid depending on your definition of what 
> /sys/bus/pci/slots/<slot_no>/power should do.
> 
> Is it intended to just power down the adapter that's in the slot, 
> or is it intended to make the adapter in the slot able to be removed?
> If it's intended to make the adapter able to be removed, shouldn't
> we be calling _EJ0?
> 
> As a comparison, in pciehp when the sysfs power file is written,
> we do actually go out and send the commands to the hotplug controller
> to physically power off the slot.

Kristen, This sounds a lot like the problem I was trying to address 
with the "fix slot poweroff problem on systems without _PS3" patch 
that I posted in June.
http://sourceforge.net/mailarchive/forum.php?thread_name=20070604232736.GA3239%40us.ibm.com&forum_name=pcihpd-discuss
It seems to be working fine on our systems.

Gary

-- 
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503  IBM T/L: 775-4503
garyhade@us.ibm.com
http://www.ibm.com/linux/ltc

  parent reply	other threads:[~2007-10-01 17:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-01 17:08 what is writing to /sys/bus/pci/slot/<slot_no>/power really supposed to do? Kristen Carlson Accardi
2007-10-01 17:19 ` Greg KH
2007-10-01 17:35   ` Kristen Carlson Accardi
2007-10-01 17:46     ` [Pcihpd-discuss] " Matthew Wilcox
2007-10-01 17:43 ` Gary Hade [this message]
2007-10-01 17:50   ` Kristen Carlson Accardi
2007-10-01 18:33     ` Gary Hade
2007-10-01 18:39       ` Gary Hade
2007-10-01 18:43       ` Kristen Carlson Accardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071001174340.GA10858@us.ibm.com \
    --to=garyhade@us.ibm.com \
    --cc=gregkh@suse.de \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=pcihpd-discuss@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.