All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 1/11]: Auxiliary function for smallest-fit option lengths
Date: Mon, 01 Oct 2007 17:33:37 +0000	[thread overview]
Message-ID: <200710011833.37867@strip-the-willow> (raw)
In-Reply-To: <200710011518.11436@strip-the-willow>

Quoting Arnaldo Carvalho de Melo:
|  > +/* Find smallest-fit for @value, but not more than 6 bytes (current maximum) */
|  > +static inline u8 dccp_bytes_per_value(const u64 value)
|  > +{
|  > +     if (value > 0xFFFFFFFFull)
|  > +             return 6;
|  > +     return value > 0xFFFF? 4 : (value > 0xFF? 2 : 1);
|  
|  Gerrit, one more coding style request: please always add an space after
|  the '?'.
Thank you for spotting - I will take this `home' and do the same for all patches in the
test tree.
I wish I could save you these requests, but the question of space or not space was not 
very clear to me - I could find 

Will in any case also re-read Documentation/CodingStyle and update the patches if anything is not
conform.

Gerrit	

  parent reply	other threads:[~2007-10-01 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-01 14:18 [PATCH 1/11]: Auxiliary function for smallest-fit option lengths Gerrit Renker
2007-10-01 14:47 ` [PATCH 1/11]: Auxiliary function for smallest-fit option Arnaldo Carvalho de Melo
2007-10-01 17:33 ` Gerrit Renker [this message]
2007-10-01 20:14 ` [PATCH 1/11]: Auxiliary function for smallest-fit option lengths Ian McDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710011833.37867@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.