From: Andi Kleen <ak@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: David Bahi <dbahi@novell.com>,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Gregory Haskins <GHaskins@novell.com>
Subject: Re: nmi_watchdog fix for x86_64 to be more like i386
Date: Mon, 1 Oct 2007 21:16:59 +0200 [thread overview]
Message-ID: <200710012116.59356.ak@suse.de> (raw)
In-Reply-To: <alpine.LFD.0.9999.0710012052310.20478@localhost.localdomain>
On Monday 01 October 2007 20:54:21 Thomas Gleixner wrote:
> On Mon, 1 Oct 2007, Andi Kleen wrote:
>
> > On Wednesday 26 September 2007 20:03:12 David Bahi wrote:
> > > Thanks to tglx and ghaskins for all the help in tracking down a very
> > > early nmi_watchdog crash on certain x86_64 machines.
> >
> > The patch is totally bogus. irq 0 doesn't say anything about whether
> > the current CPU still works or not. You always need some local
> > interrupt. This basically disables the NMI watchdog for the non boot CPUs.
> >
> > It's even wrong on i386 -- i wonder how that broken patch
> > made it in there. I'll remove it there.
>
> Right, it's wrong for the broadcast case, but simply removing it will
> trigger false positives on the CPU which runs the broadcast timer. I
> fix this proper.
I already did this here by checking for cpu != 0. But it also needs either tracking
or forbidding migrations of irq 0. I can take care of the patch.
-Andi
next prev parent reply other threads:[~2007-10-01 19:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 18:03 nmi_watchdog fix for x86_64 to be more like i386 David Bahi
2007-10-01 17:36 ` Andi Kleen
2007-10-01 18:54 ` Thomas Gleixner
2007-10-01 19:16 ` Andi Kleen [this message]
2007-10-01 19:27 ` Thomas Gleixner
2007-10-01 19:56 ` Arjan van de Ven
2007-10-01 20:10 ` Dave Jones
2007-10-01 20:11 ` Paul E. McKenney
2007-10-01 21:17 ` Thomas Gleixner
2007-10-01 21:41 ` Andi Kleen
2007-10-01 21:58 ` Thomas Gleixner
2007-10-01 22:07 ` Andi Kleen
2007-10-01 22:47 ` Thomas Gleixner
2007-10-01 22:52 ` Arjan van de Ven
2007-10-02 4:56 ` Mika Penttilä
2007-10-02 5:00 ` Arjan van de Ven
2007-10-02 5:51 ` Andi Kleen
2007-10-02 6:18 ` Thomas Gleixner
2007-10-05 4:37 ` Pallipadi, Venkatesh
2007-10-05 20:37 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2007-10-05 16:01 David Bahi
2007-10-05 16:03 ` Andi Kleen
2007-10-05 17:38 ` Peter W. Morreale
2007-10-05 18:00 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710012116.59356.ak@suse.de \
--to=ak@suse.de \
--cc=GHaskins@novell.com \
--cc=dbahi@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.