From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 4/9]: Resolve dependencies of features on choice of CCID
Date: Tue, 02 Oct 2007 11:47:12 +0000 [thread overview]
Message-ID: <200710021247.12463@strip-the-willow> (raw)
In-Reply-To: <200709281630.22458@strip-the-willow>
| I don't quite understand why you're defining on and off when there is
| built in stuff for the kernel for true/false. You then pass the
| address of the on/off - not the value. Maybe you might like to explain
| the rationale behind this as I'm probably missing something.
No you are not - thanks so much for pointing this out! These constants have
been a constant eyesore and I had wanted to get rid of them, but lacked an
idea.
The pointer was used to have a sentinel in the table, since the caller can not
know how large the table is. But a look at RFC 4340, 6.4 showed that `0' is
never a valid feature number, so that is used as an end-of-table condition now.
Thanks a lot.
prev parent reply other threads:[~2007-10-02 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 15:30 [PATCH 4/9]: Resolve dependencies of features on choice of CCID Gerrit Renker
2007-10-01 18:40 ` Ian McDonald
2007-10-02 11:47 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710021247.12463@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.