From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 5/11]: Update insertion routine for feature-negotiation options
Date: Tue, 02 Oct 2007 12:27:05 +0000 [thread overview]
Message-ID: <200710021327.05763@strip-the-willow> (raw)
In-Reply-To: <200710011518.21775@strip-the-willow>
Quoting Ian McDonald:
| > @@ -124,4 +124,5 @@ extern void dccp_encode_value_var(const
| > extern u64 dccp_decode_value_var(const u8 *bf, const u8 len);
| >
| > extern int dccp_insert_option_mandatory(struct sk_buff *skb);
| > +extern int dccp_insert_fn_opt(struct sk_buff *skb, u8, u8, u8 *, u8, bool);
|
| declarations in kernel should always have parameter names.
I personally disagree since I would look at the function itself to tell me what it
does (the above had carefully been butchered to match the other constraint of 80 linechars).
But I have changed it to the following (I omit the entire patch, the whole lot will be put
in the test tree when the discussion phase is over); the inter-diff is:
--- a/net/dccp/feat.h
+++ b/net/dccp/feat.h
@@ -124,5 +124,6 @@ extern void dccp_encode_value_var(const
extern u64 dccp_decode_value_var(const u8 *bf, const u8 len);
extern int dccp_insert_option_mandatory(struct sk_buff *skb);
-extern int dccp_insert_fn_opt(struct sk_buff *skb, u8, u8, u8 *, u8, bool);
+extern int dccp_insert_fn_opt(struct sk_buff *skb, u8 type, u8 feat,
+ u8 *val, u8 len, bool repeat_first);
#endif /* _DCCP_FEAT_H */
prev parent reply other threads:[~2007-10-02 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 14:18 [PATCH 5/11]: Update insertion routine for feature-negotiation options Gerrit Renker
2007-10-01 22:50 ` Ian McDonald
2007-10-02 12:27 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710021327.05763@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.