From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH v2 4/9]: Resolve dependencies of features on choice of CCID
Date: Tue, 02 Oct 2007 15:27:07 +0000 [thread overview]
Message-ID: <200710021627.07615@strip-the-willow> (raw)
In-Reply-To: <200710021306.55993@strip-the-willow>
Quoting Arnaldo Carvalho de Melo:
| > + { /* !is_local: dependencies of the remote (RX) CCID */
| > + { DCCPF_SEND_ACK_VECTOR, true, true, 1 },
| > + { 0, 0, 0, 0 }
|
| designated initializers, please, that way we can avoid the zeroes and
| see the name of the fields, which helps understanding without having to
| go back to the struct definition.
I can add the field-wise initialisers, but have no way of getting rid of the zeroes
at the moment. The problem is that
* the dependencies of the feature-location can be different from
* the dependencies of the feature-remote
as is indeed the case with ccid3_dependencies[2][5]: it which has three dependencies for the
feature-remote, but four for the feature-local.
So the tables can be variable in length, even in their two main rows. The number of
rows (2), on the other hand, is given by the requirement that features divide into
local/remote, so there is no problem using a fixed-length.
If you can think of a more elegant solution of tackling this, I'd welcome suggestions.
Will axe the `const typedef' stuff, thanks.
next prev parent reply other threads:[~2007-10-02 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 12:06 [PATCH v2 4/9]: Resolve dependencies of features on choice of CCID Gerrit Renker
2007-10-02 14:57 ` [PATCH v2 4/9]: Resolve dependencies of features on choice of Arnaldo Carvalho de Melo
2007-10-02 15:27 ` Gerrit Renker [this message]
2007-10-02 22:03 ` [PATCH v2 4/9]: Resolve dependencies of features on choice of CCID Ian McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710021627.07615@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.