From: Ralf Baechle <ralf@linux-mips.org>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH][2/4] move Cobalt UART base definition to arch/mips/cobalt/console.c
Date: Tue, 2 Oct 2007 21:14:58 +0100 [thread overview]
Message-ID: <20071002201458.GA16476@linux-mips.org> (raw)
In-Reply-To: <20071002231317.0fbaf7bb.yoichi_yuasa@tripeaks.co.jp>
On Tue, Oct 02, 2007 at 11:13:17PM +0900, Yoichi Yuasa wrote:
> diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/cobalt/console.c mips/arch/mips/cobalt/console.c
> --- mips-orig/arch/mips/cobalt/console.c 2007-09-30 21:21:39.610319250 +0900
> +++ mips/arch/mips/cobalt/console.c 2007-09-30 21:26:10.135226000 +0900
> @@ -1,16 +1,15 @@
> /*
> * (C) P. Horton 2006
> */
> +#include <linux/io.h>
> #include <linux/serial_reg.h>
>
> -#include <asm/addrspace.h>
> -
> -#include <cobalt.h>
> +#define UART_BASE ((void __iomem *)CKSEG1ADDR(0x1c800000))
>
> void prom_putchar(char c)
> {
> - while(!(COBALT_UART[UART_LSR] & UART_LSR_THRE))
> + while(!(readb(UART_BASE + UART_LSR) & UART_LSR_THRE))
^^^
missing space.
Aside of that looks ok, so I fixed that up and queued all four patches
for 2.6.24.
Thanks,
Ralf
prev parent reply other threads:[~2007-10-02 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 13:54 [PATCH][1/4] move Cobalt PCI definitions to arch/mips/pci/fixup-cobalt.c Yoichi Yuasa
2007-10-02 14:13 ` [PATCH][2/4] move Cobalt UART base definition to arch/mips/cobalt/console.c Yoichi Yuasa
2007-10-02 14:17 ` [PATCH][3/4] move Cobalt reset port definition to arch/mips/cobalt/reset.c Yoichi Yuasa
2007-10-02 14:21 ` [PATCH][4/4] remove cobalt_machine_power_off() Yoichi Yuasa
2007-10-02 20:14 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071002201458.GA16476@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.