From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de,
Larry Finger <larry.finger@lwfinger.net>
Subject: Re: [PATCH] b43: Leds spinlock SMP compilefix
Date: Tue, 2 Oct 2007 16:20:53 -0400 [thread overview]
Message-ID: <20071002202053.GB29361@tuxdriver.com> (raw)
In-Reply-To: <200709300004.36905.mb@bu3sch.de>
I'll just roll this into the "b43: LED triggers support" patch.
Thanks,
John
On Sun, Sep 30, 2007 at 12:04:36AM +0200, Michael Buesch wrote:
> This was missing an address operator.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> Index: wireless-2.6/drivers/net/wireless/b43/leds.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/b43/leds.c 2007-09-29 12:44:08.000000000 +0200
> +++ wireless-2.6/drivers/net/wireless/b43/leds.c 2007-09-30 00:02:18.000000000 +0200
> @@ -37,14 +37,14 @@ static void b43_led_turn_on(struct b43_w
> unsigned long flags;
> u16 ctl;
>
> - spin_lock_irqsave(wl->leds_lock, flags);
> + spin_lock_irqsave(&wl->leds_lock, flags);
> ctl = b43_read16(dev, B43_MMIO_GPIO_CONTROL);
> if (activelow)
> ctl &= ~(1 << led_index);
> else
> ctl |= (1 << led_index);
> b43_write16(dev, B43_MMIO_GPIO_CONTROL, ctl);
> - spin_unlock_irqrestore(wl->leds_lock, flags);
> + spin_unlock_irqrestore(&wl->leds_lock, flags);
> }
>
> static void b43_led_turn_off(struct b43_wldev *dev, u8 led_index,
> @@ -54,14 +54,14 @@ static void b43_led_turn_off(struct b43_
> unsigned long flags;
> u16 ctl;
>
> - spin_lock_irqsave(wl->leds_lock, flags);
> + spin_lock_irqsave(&wl->leds_lock, flags);
> ctl = b43_read16(dev, B43_MMIO_GPIO_CONTROL);
> if (activelow)
> ctl |= (1 << led_index);
> else
> ctl &= ~(1 << led_index);
> b43_write16(dev, B43_MMIO_GPIO_CONTROL, ctl);
> - spin_unlock_irqrestore(wl->leds_lock, flags);
> + spin_unlock_irqrestore(&wl->leds_lock, flags);
> }
>
> /* Callback from the LED subsystem. */
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-10-02 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 22:04 [PATCH] b43: Leds spinlock SMP compilefix Michael Buesch
2007-10-02 20:20 ` John W. Linville [this message]
2007-10-02 20:41 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071002202053.GB29361@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.