From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IcpTO-0003Oq-W1 for mharc-grub-devel@gnu.org; Tue, 02 Oct 2007 17:40:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IcpTM-0003Nw-GM for grub-devel@gnu.org; Tue, 02 Oct 2007 17:40:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IcpTK-0003NK-UV for grub-devel@gnu.org; Tue, 02 Oct 2007 17:40:08 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IcpTK-0003ND-Qv for grub-devel@gnu.org; Tue, 02 Oct 2007 17:40:06 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IcpTK-0006Vx-Hq for grub-devel@gnu.org; Tue, 02 Oct 2007 17:40:06 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IcpTI-00070R-N3 for grub-devel@gnu.org; Tue, 02 Oct 2007 23:40:05 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IcpSw-0002Yf-35 for grub-devel@gnu.org; Tue, 02 Oct 2007 23:39:42 +0200 Date: Tue, 2 Oct 2007 23:39:42 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071002213942.GC29487@thorin> References: <8a2a06bb0710010357u142f6ba4gb053afde829f0f39@mail.gmail.com> <20071001123345.GB20428@thorin> <8a2a06bb0710011114l5cc66483vc27b0b83eb3395e1@mail.gmail.com> <20071001183927.GA10233@thorin> <8a2a06bb0710011243m38ac71a0t463b6ea56ff19e78@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a2a06bb0710011243m38ac71a0t463b6ea56ff19e78@mail.gmail.com> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-Detected-Kernel: Genre and OS details not recognized. Subject: Re: [PATCH] Fixed ieee1275 console X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 21:40:08 -0000 On Mon, Oct 01, 2007 at 09:43:27PM +0200, Marcin Kurek wrote: > Hell[o] > > > Is this a bitmask? In this case, looks like you aren't using the right > > numbers. Now GRUB_TERM_SIMPLE_MENU == GRUB_TERM_DUMB | GRUB_TERM_NO_EDIT > > OTOH if that's what you intended, I think it's better to build one macro > > using the others. > > Eeeek, why ? The flags are checked using 'flags & ' as I can see > in kern/term.c, then how (1 << 3) can be evaluated as (1 << 1) and (1 > << 2) in this case ? Oops, sorry. That was an oversight. (why does it jump directly from 4 to 16??). > > This part doesn't look right. vesa/vga is a whole different history. At the > > least vesa *does* support unicode. > > But both remaps border codes to cp437 and my code change only this > part, the unicode support is still there I does not touch it. Oh, that's odd. I thought it would be using utf-8 directly. > > Have you verified that grub-emu still builds / works? > > It does not build for ieee1275 on cvs because missing util/hostfs.c in > powerpc-ieee1275.rmk, but after adding it builds/runs fine. Fixed, thanks. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)