From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 9/15] cs5530: remove needless ide_lock taking
Date: Tue, 2 Oct 2007 23:02:20 +0200 [thread overview]
Message-ID: <200710022302.20574.bzolnier@gmail.com> (raw)
In-Reply-To: <20071002144541.1832b74d@the-village.bc.nu>
On Tuesday 02 October 2007, Alan Cox wrote:
> > - spin_lock_irqsave(&ide_lock, flags);
> > - /* all CPUs (there should only be one CPU with this chipset) */
> > -
>
> NAK
>
> What about pre-emptible kernels. Put in a private lock.
All the removed code resided in init_chipset_cs5530() which is called only
during the controller initialization. Moreover pata_cs5530 also don't have
any locking in cs5530_init_chip().
Bart
next prev parent reply other threads:[~2007-10-02 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 21:37 [PATCH 9/15] cs5530: remove needless ide_lock taking Bartlomiej Zolnierkiewicz
2007-10-02 13:00 ` Sergei Shtylyov
2007-10-02 13:45 ` Alan Cox
2007-10-02 21:02 ` Bartlomiej Zolnierkiewicz [this message]
2007-10-03 0:14 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710022302.20574.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.