From: akepner@sgi.com
To: Roland Dreier <rdreier@cisco.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Jes Sorensen <jes@sgi.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
James Bottomley <James.Bottomley@steeleye.com>,
linux-kernel@vger.kernel.org
Subject: Re: [4/4] mthca: allow setting "dmabarrier" on user-allocated memory
Date: Tue, 2 Oct 2007 18:02:25 -0700 [thread overview]
Message-ID: <20071003010225.GC26752@sgi.com> (raw)
In-Reply-To: <ada3awyo9hz.fsf@cisco.com>
On Fri, Sep 28, 2007 at 12:50:00PM -0700, Roland Dreier wrote:
> Sorry for not mentioning this earlier, but this patch should really be
> two (or more) patches: one to add dmabarrier support to the core user
> memory stuff in drivers/infiniband, and a second one to add support to
> mthca (and more patches to add support to mlx4, cxgb3, etc, etc).
Makes sense.
>
> > + * @dmabarrier: set "dmabarrier" attribute on this memory, if necessary
>
> Nit: just delete the "if necessary" since I don't think it makes
> things clearer (and actually doesn't make much sense in this context)
>
OK.
> Other than that this look fine to me, and I'm ready to merge it once
> the necessary core DMA stuff is settled.
>
Great. A new version of the patchset is on the way.
--
Arthur
prev parent reply other threads:[~2007-10-03 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 1:13 [4/4] mthca: allow setting "dmabarrier" on user-allocated memory akepner
2007-09-28 19:50 ` Roland Dreier
2007-10-03 1:02 ` akepner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071003010225.GC26752@sgi.com \
--to=akepner@sgi.com \
--cc=James.Bottomley@steeleye.com \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.