From: akepner@sgi.com
To: David Miller <davem@davemloft.net>
Cc: grundler@parisc-linux.org, jbarnes@virtuousgeek.org, jes@sgi.com,
randy.dunlap@oracle.com, rdreier@cisco.com,
James.Bottomley@steeleye.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] allow drivers to flush in-flight DMA v2
Date: Tue, 2 Oct 2007 18:04:55 -0700 [thread overview]
Message-ID: <20071003010455.GD26752@sgi.com> (raw)
In-Reply-To: <20070928.154339.02281405.davem@davemloft.net>
On Fri, Sep 28, 2007 at 03:43:39PM -0700, David Miller wrote:
> ....
> My only beef with this patch set is that it seems
> a bit much to create a totally new function name every
> time we want to set some kind of new attribute on some
> DMA object. Why not add a "dma_set_flags()" or similar
> that can be used later on to set other kinds of aspects
> we'd like to change?
>
> You can make the arguments "u32 flags" and "int dir".
> Actually you should probably use the dma direction
> enumaration instead of 'int'.
OK, this will be in the next version along with the
coding style changes you mentioned.
--
Arthur
next prev parent reply other threads:[~2007-10-03 1:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 1:09 [PATCH 0/4] allow drivers to flush in-flight DMA v2 akepner
2007-09-28 22:43 ` David Miller
2007-10-03 1:04 ` akepner [this message]
2007-10-03 17:10 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071003010455.GD26752@sgi.com \
--to=akepner@sgi.com \
--cc=James.Bottomley@steeleye.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.