From: iank@bredband.net
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: pomac@vapor.com, Jeff Garzik <jgarzik@pobox.com>,
Linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: jumbo frame regression fix
Date: Wed, 3 Oct 2007 10:29:32 +0200 [thread overview]
Message-ID: <20071003082932.GD32073@pomac.netswarm.net> (raw)
In-Reply-To: <20071002215914.13d1e8cf@freepuppy.rosehill>
On Tue, Oct 02, 2007 at 09:59:14PM -0700, Stephen Hemminger wrote:
> On Wed, 03 Oct 2007 03:34:34 +0200
> Ian Kumlien <pomac@vapor.com> wrote:
>
> > On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote:
> > > Remove unneeded check that caused problems with jumbo frame sizes.
> > > The check was recently added and is wrong.
> > > When using jumbo frames the sky2 driver does fragmentation, so
> > > rx_data_size is less than mtu.
> >
> > Confirmed working.
> >
> > Now running with 9k mtu with no errors, =)
> >
> > It also seems that the FIFO bug was the one that affected me before,
> > damn odd race that one.
>
> Does the workaround (forced reset work). Ian, you are the first person to
> report triggering it. I haven't found a way to make it happen.
> What combination of flow control and speeds are you using?
I forgot to add, last time was -rc8-git2 or 3 and using Westwood flow
control.
> --
> Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-03 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 0:42 [BUG] sky2 errors in 2.6.23-rc9-git1 Ian Kumlien
2007-10-03 1:02 ` [PATCH] sky2: jumbo frame regression fix Stephen Hemminger
2007-10-03 1:07 ` Jeff Garzik
2007-10-03 4:53 ` Stephen Hemminger
2007-10-03 4:58 ` Jeff Garzik
2007-10-03 1:34 ` Ian Kumlien
2007-10-03 4:59 ` Stephen Hemminger
2007-10-03 7:37 ` Ian Kumlien
2007-10-03 8:29 ` iank [this message]
2007-11-24 16:23 ` [SKY2] Problems (2.6.24-rc3-git1) Ian Kumlien
2007-11-27 22:40 ` Ian Kumlien
2007-11-27 22:57 ` Stephen Hemminger
2007-11-27 23:07 ` Ian Kumlien
2007-10-03 18:04 ` [PATCH] sky2: jumbo frame regression fix Bill Davidsen
2007-10-03 18:28 ` Ian Kumlien
2007-10-03 17:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071003082932.GD32073@pomac.netswarm.net \
--to=iank@bredband.net \
--cc=Linux-kernel@vger.kernel.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=pomac@vapor.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.