From: akepner@sgi.com
To: Heikki Orsila <shdl@zakalwe.fi>
Cc: Grant Grundler <grundler@parisc-linux.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Jes Sorensen <jes@sgi.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
RolandDreier <rdreier@cisco.com>,
James Bottomley <James.Bottomley@steeleye.com>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] mthca: allow setting "dmabarrier" on user-allocated memory
Date: Wed, 3 Oct 2007 10:29:27 -0700 [thread overview]
Message-ID: <20071003172927.GO26752@sgi.com> (raw)
In-Reply-To: <20071003025645.GM3400@zakalwe.fi>
On Wed, Oct 03, 2007 at 05:56:45AM +0300, Heikki Orsila wrote:
> On Tue, Oct 02, 2007 at 07:50:07PM -0700, akepner@sgi.com wrote:
> > +struct mthca_reg_mr {
> > + __u32 mr_attrs;
> > +#define MTHCA_MR_DMAFLUSH 0x1 /* flush in-flight DMA on a write to
> > + * memory region */
> > + __u32 reserved;
> > +};
>
> Seems like a very odd place to #define something new..
>
Lots of drivers do that - #define flags or whatever near the
variable to which they apply. Didn't see any examples in the
mthca driver though, so maybe it's setting a precedent there.
If the maintainer objects, I'll move it.
--
Arthur
prev parent reply other threads:[~2007-10-03 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 2:50 [PATCH 5/5] mthca: allow setting "dmabarrier" on user-allocated memory akepner
2007-10-03 2:56 ` Heikki Orsila
2007-10-03 17:29 ` akepner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071003172927.GO26752@sgi.com \
--to=akepner@sgi.com \
--cc=James.Bottomley@steeleye.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=shdl@zakalwe.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.