From: Martin Waitz <tali@admingilde.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Ericsson <ae@op5.se>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] git-init: don't base core.filemode on the ability to chmod.
Date: Thu, 4 Oct 2007 09:17:51 +0200 [thread overview]
Message-ID: <20071004071751.GD20800@admingilde.org> (raw)
In-Reply-To: <7vr6kbbdph.fsf@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
hoi :)
On Wed, Oct 03, 2007 at 11:23:22PM -0700, Junio C Hamano wrote:
> filemode = !( (st1.st_mode & S_IXUSR)
> /* we did not ask for x-bit -- bogus FS */
> || chmod(path, st1.st_mode & S_IXUSR)
> /* it does not let us flip x-bit -- bogus FS */
> || lstat(path, &st2)
> /* it does not let us read back -- bogus FS */
> || (st1.st_mode == st2.st_mode)
> /* it forgets we flipped -- bogus FS */
> );
that looks good.
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-10-04 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 10:55 [PATCH] git-init: don't base core.filemode on the ability to chmod Martin Waitz
2007-10-03 12:19 ` Johannes Sixt
2007-10-03 23:19 ` Martin Waitz
2007-10-03 23:54 ` Johannes Schindelin
2007-10-04 6:05 ` Andreas Ericsson
2007-10-04 6:23 ` Junio C Hamano
2007-10-04 7:17 ` Martin Waitz [this message]
2007-10-04 8:21 ` Junio C Hamano
2007-10-04 8:36 ` Johannes Sixt
2007-10-04 8:42 ` Martin Waitz
2007-10-10 9:47 ` Jan Hudec
2007-10-04 12:49 ` Johannes Schindelin
2007-10-04 10:33 ` Andreas Ericsson
2007-10-04 7:15 ` Martin Waitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004071751.GD20800@admingilde.org \
--to=tali@admingilde.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.