From: Ingo Molnar <mingo@elte.hu>
To: Mike Kravetz <kravetz@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Clark Williams <williams@redhat.com>
Subject: Re: -rt scheduling: wakeup bug?
Date: Thu, 4 Oct 2007 10:02:17 +0200 [thread overview]
Message-ID: <20071004080217.GE9176@elte.hu> (raw)
In-Reply-To: <20071003173705.GB4817@monkey.ibm.com>
* Mike Kravetz <kravetz@us.ibm.com> wrote:
> > if (rq->curr && p && rq && _need_resched())
> > trace_special_pid(p->pid, PRIO(p), PRIO(rq->curr));
>
> Not an issue with the patch, just that last bit of code pulled in for
> context. I don't think it is a bug, but the checking of 'rq' after
> checking 'rq->curr' just doesn't look right (or necessary). Could it
> just be an artifact from earlier versions of the code?
yeah, you are right - and rq shouldnt ever be NULL there anyway.
Ingo
prev parent reply other threads:[~2007-10-04 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 22:15 RT scheduling: wakeup bug? Mike Kravetz
2007-10-02 5:06 ` -rt " Ingo Molnar
2007-10-02 19:30 ` Mike Kravetz
2007-10-02 19:37 ` Steven Rostedt
2007-10-03 17:37 ` Mike Kravetz
2007-10-04 8:02 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004080217.GE9176@elte.hu \
--to=mingo@elte.hu \
--cc=kravetz@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.