All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: w@1wt.eu, apw@shadowen.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] printk: add KERN_CONT annotation
Date: Thu, 4 Oct 2007 13:43:20 -0700	[thread overview]
Message-ID: <20071004134320.a9160974.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071002051852.GC28345@elte.hu>

On Tue, 2 Oct 2007 07:18:52 +0200
Ingo Molnar <mingo@elte.hu> wrote:

> 
> printk: add the KERN_CONT annotation (which is empty string but via 
> which checkpatch.pl can notice that the lacking KERN_ level is fine). 
> This useful for multiple calls of hand-crafted printk output done by 
> early debug code or similar.
> 

I like it.  Sort of self-documenting notation.

> 
> Index: linux/include/linux/kernel.h
> ===================================================================
> --- linux.orig/include/linux/kernel.h
> +++ linux/include/linux/kernel.h
> @@ -61,6 +61,13 @@ extern const char linux_proc_banner[];
>  #define	KERN_INFO	"<6>"	/* informational			*/
>  #define	KERN_DEBUG	"<7>"	/* debug-level messages			*/
>  
> +/*
> + * Annotation for a "continued" line of log printout (only done after a
> + * line that had no enclosing \n). Only to be used by core/arch code
> + * during early bootup (a continued line is not SMP-safe otherwise).
> + */
> +#define	KERN_CONT	""
> +
>  extern int console_printk[];
>  
>  #define console_loglevel (console_printk[0])
> Index: linux/kernel/sched.c

I get rejects from the sched.c hunk and that's your stuff anwyay, so I
dropped that bit.


  parent reply	other threads:[~2007-10-04 20:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070928105345.GC18163@shadowen.org>
2007-10-01  6:44 ` checkpatch and kernel/sched.c Ingo Molnar
2007-10-01  7:30   ` Andrew Morton
2007-10-01  7:48     ` Avi Kivity
2007-10-01  7:39       ` Andrew Morton
2007-10-01 10:39         ` Ingo Molnar
2007-10-01  7:50     ` Sam Ravnborg
2007-10-01 10:37     ` Ingo Molnar
2007-10-01 10:44     ` Ingo Molnar
2007-10-01 12:34     ` Andy Whitcroft
2007-10-02  4:34     ` Willy Tarreau
2007-10-02  5:18       ` [patch] printk: add KERN_CONT annotation Ingo Molnar
2007-10-02 10:04         ` Jörn Engel
2007-10-02 15:41         ` Joe Perches
2007-10-02 15:45           ` Jan Engelhardt
2007-10-02 16:03             ` Joe Perches
2007-10-02 16:07               ` Jan Engelhardt
2007-10-04 20:43         ` Andrew Morton [this message]
2007-10-04 20:52           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071004134320.a9160974.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.