From: Ralf Baechle <ralf@linux-mips.org>
To: Giuseppe Sacco <giuseppe@eppesuigoccas.homedns.org>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] enable PCI bridges in MIPS ip32
Date: Thu, 4 Oct 2007 16:19:51 +0100 [thread overview]
Message-ID: <20071004151951.GD6897@linux-mips.org> (raw)
In-Reply-To: <1191508413.10050.26.camel@scarafaggio>
On Thu, Oct 04, 2007 at 04:33:33PM +0200, Giuseppe Sacco wrote:
> Il giorno gio, 04/10/2007 alle 14.03 +0100, Ralf Baechle ha scritto:
> [...]
> > (of course this all goes far beyond Giuseppe's patch - but the whole
> > ops-mace.c file like so much of the other code in arch/mips/pci isn't
> > exactly an example to be copied.
> >
> > Ah, one final formality - when sending a patch please add a
> > Signed-off-by: line. See Documentation/SubmittingPatches in the kernel
> > tree for what this means.
>
> I'll provide a new patch tomorrow, using inline functions instead of
> macros. About the maximum number of PCI buses, I used 1 since the ip32
> only have 1 slot. If this maximum value should be changed, please let me
> know.
The entire testing done by chkslot() is probably not needed, so I suggest
you try to simply dump the thing entirely and test.
Ralf
next prev parent reply other threads:[~2007-10-04 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 10:32 [PATCH] enable PCI bridges in MIPS ip32 Giuseppe Sacco
2007-10-04 12:27 ` Maciej W. Rozycki
2007-10-04 12:50 ` Giuseppe Sacco
2007-10-04 13:03 ` Ralf Baechle
2007-10-04 14:13 ` Maciej W. Rozycki
2007-10-04 16:55 ` Ralf Baechle
2007-10-05 12:10 ` Maciej W. Rozycki
2007-10-05 12:27 ` Maciej W. Rozycki
2007-10-04 14:33 ` Giuseppe Sacco
2007-10-04 15:03 ` Maciej W. Rozycki
2007-10-04 15:19 ` Ralf Baechle [this message]
2007-10-04 15:27 ` Maciej W. Rozycki
2007-10-04 15:32 ` Ralf Baechle
2007-10-05 5:33 ` Giuseppe Sacco
2007-10-05 11:53 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004151951.GD6897@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=giuseppe@eppesuigoccas.homedns.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.