All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/3 RESEND 2] hwmon/dme1737: cleanups
Date: Thu, 04 Oct 2007 15:23:45 +0000	[thread overview]
Message-ID: <20071004172345.7180eeb9@hyperion.delvare> (raw)
In-Reply-To: <191fb4ca0710012119s713699efhd479c6326c9dbcb@mail.gmail.com>

On Mon, 1 Oct 2007 21:19:04 -0700, Juerg Haefliger wrote:
> This patch cleans up and prepares the dme1737 driver for support of the sch311x
> chips. (Almost) no functional changes.
> 
> - Replaced whitespaces with tabs.
> - Removed empty lines.
> - Added _i2c_ to names of functions that are strictly I2C related.
> - Added 4 new functions: dme1737_create_files, dme1737_remove_files,
>  dme1737_sio_enter, and dme1737_sio_exit.
> - Added error messages in case client attach/detach fails.

Not really, as you backed up (most of) these changes. Anyway...

> Signed-off-by: Juerg Haefliger <juergh at gmail.com>

Acked-by: Jean Delvare <khali@linux-fr.org>

Note that I had to replace all occurrences of "class_dev" to
"hwmon_dev", otherwise this patch doesn't apply on top of "hwmon:
Convert from class_device to device" in Mark's tree.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2007-10-04 15:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-02  4:19 [lm-sensors] [PATCH 1/3 RESEND 2] hwmon/dme1737: cleanups Juerg Haefliger
2007-10-04 15:23 ` Jean Delvare [this message]
2007-10-05  4:15 ` Juerg Haefliger
2007-10-05  9:45 ` Jean Delvare
2007-10-11  4:10 ` Mark M. Hoffman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071004172345.7180eeb9@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.