From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Idjyj-0004hx-Ba for mharc-grub-devel@gnu.org; Fri, 05 Oct 2007 06:00:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Idjyh-0004fx-Qv for grub-devel@gnu.org; Fri, 05 Oct 2007 06:00:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Idjyc-0004bj-T0 for grub-devel@gnu.org; Fri, 05 Oct 2007 06:00:13 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Idjyc-0004bU-3V for grub-devel@gnu.org; Fri, 05 Oct 2007 06:00:10 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Idjyb-0001n9-Ob for grub-devel@gnu.org; Fri, 05 Oct 2007 06:00:09 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Idjya-0005CO-95 for grub-devel@gnu.org; Fri, 05 Oct 2007 12:00:08 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IdjyG-0007Fm-7n for grub-devel@gnu.org; Fri, 05 Oct 2007 11:59:48 +0200 Date: Fri, 5 Oct 2007 11:59:48 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20071005095948.GA27825@thorin> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-Detected-Kernel: Genre and OS details not recognized. Subject: [PATCH] do not require that device is a partition X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 10:00:16 -0000 --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! Devices where the filesystem is in whole disk are common nowadays [1]; I don't think it's a good idea to require that a filesystem is in a partition in order to access it. See attached patch. Any comments? [1] for example, debian provides usb images of the debian-installer with a fat filesystem and no partitions: http://people.debian.org/~joeyh/d-i/images/daily/hd-media/boot.img.gz -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) --WIyZ46R2i8wDzkSu Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="disk_fs.diff" 2007-10-05 Robert Millan * normal/misc.c (grub_normal_print_device_info): Do not require that device is a partition. diff -ur grub2/normal/misc.c grub2.disk_fs/normal/misc.c --- grub2/normal/misc.c 2007-07-22 01:32:29.000000000 +0200 +++ grub2.disk_fs/normal/misc.c 2007-10-05 11:55:29.000000000 +0200 @@ -40,7 +40,7 @@ dev = grub_device_open (name); if (! dev) grub_printf ("Filesystem cannot be accessed"); - else if (! dev->disk || ! dev->disk->has_partitions || dev->disk->partition) + else { char *label; grub_fs_t fs; --WIyZ46R2i8wDzkSu--