From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IdmKD-0003UD-2M for mharc-grub-devel@gnu.org; Fri, 05 Oct 2007 08:30:37 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IdmK9-0003SH-38 for grub-devel@gnu.org; Fri, 05 Oct 2007 08:30:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IdmK7-0003Rb-C0 for grub-devel@gnu.org; Fri, 05 Oct 2007 08:30:31 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdmK6-0003RK-UD for grub-devel@gnu.org; Fri, 05 Oct 2007 08:30:30 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IdmK6-0007Ei-FW for grub-devel@gnu.org; Fri, 05 Oct 2007 08:30:30 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IdmK5-0005Q1-2e for grub-devel@gnu.org; Fri, 05 Oct 2007 14:30:29 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IdmJk-000132-Di for grub-devel@gnu.org; Fri, 05 Oct 2007 14:30:08 +0200 Date: Fri, 5 Oct 2007 14:30:08 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20071005123008.GA3916@thorin> References: <20071005095948.GA27825@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071005095948.GA27825@thorin> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-Detected-Kernel: Genre and OS details not recognized. Subject: Re: [PATCH] do not require that device is a partition X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 12:30:34 -0000 On Fri, Oct 05, 2007 at 11:59:48AM +0200, Robert Millan wrote: > - else if (! dev->disk || ! dev->disk->has_partitions || dev->disk->partition) > + else Actually, the idea behind this check seems to be that if the device is a disk, we only want to probe for filesystems if it has no partitions. The problem with this is that filesystems in general don't garantee us that the first 512 bytes aren't filled with information that, to the MBR partition table parser, is seen as garbage and results in undefined partition layout. I think disk->has_partitions as a whole is flawed for this reason. Should we get rid of it? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)