From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + writeback-remove-pages_skipped-accounting-in-__block_write_full_page-fix.patch added to -mm tree Date: Fri, 05 Oct 2007 15:50:02 -0700 Message-ID: <200710052250.l95Mo2LE029121@imap1.linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:40233 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762212AbXJEWuN (ORCPT ); Fri, 5 Oct 2007 18:50:13 -0400 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org Cc: wfg@mail.ustc.edu.cn, akpm@linux-foundation.org, dgc@sgi.com, kenchen@google.com The patch titled writeback-remove-pages_skipped-accounting-in-__block_write_full_page fix has been added to the -mm tree. Its filename is writeback-remove-pages_skipped-accounting-in-__block_write_full_page-fix.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: writeback-remove-pages_skipped-accounting-in-__block_write_full_page fix From: Fengguang Wu On Wed, Oct 03, 2007 at 07:55:18AM +1000, David Chinner wrote: > > > > do not quite agree with each other. The page writeback should be skipped for > > 'locked buffer', but here it is 'clean buffer'! > > Ok, so that means we need an equivalent fix in xfs_start_page_writeback() > as it will skip pages with clean buffers just like this. Something like > this (untested)? Sure OK - as long as it is 'no write because of clean buffer'. The only user of pages_skipped is obviously using that semantics. Cc: Ken Chen Cc: Andrew Morton Signed-off-by: Fengguang Wu Signed-off-by: David Chinner Signed-off-by: Andrew Morton --- diff -puN fs/xfs/linux-2.6/xfs_aops.c~writeback-remove-pages_skipped-accounting-in-__block_write_full_page-fix fs/xfs/linux-2.6/xfs_aops.c --- a/fs/xfs/linux-2.6/xfs_aops.c~writeback-remove-pages_skipped-accounting-in-__block_write_full_page-fix +++ a/fs/xfs/linux-2.6/xfs_aops.c @@ -416,10 +416,9 @@ xfs_start_page_writeback( clear_page_dirty_for_io(page); set_page_writeback(page); unlock_page(page); - if (!buffers) { + /* If no buffers on the page are to be written, finish it here */ + if (!buffers) end_page_writeback(page); - wbc->pages_skipped++; /* We didn't write this page */ - } } static inline int bio_add_buffer(struct bio *bio, struct buffer_head *bh) _ Patches currently in -mm which might be from wfg@mail.ustc.edu.cn are readahead-compacting-file_ra_state.patch readahead-mmap-read-around-simplification.patch readahead-combine-file_ra_stateprev_index-prev_offset-into-prev_pos.patch readahead-combine-file_ra_stateprev_index-prev_offset-into-prev_pos-fix.patch readahead-combine-file_ra_stateprev_index-prev_offset-into-prev_pos-fix-2.patch radixtree-introduce-radix_tree_next_hole.patch readahead-basic-support-of-interleaved-reads.patch readahead-remove-the-local-copy-of-ra-in-do_generic_mapping_read.patch readahead-remove-several-readahead-macros.patch readahead-remove-the-limit-max_sectors_kb-imposed-on-max_readahead_kb.patch filemap-trivial-code-cleanups.patch filemap-convert-some-unsigned-long-to-pgoff_t.patch make-swappiness-safer-to-use.patch maps-pssproportional-set-size-accounting-in-smaps.patch convert-ill-defined-log2-to-ilog2.patch seqfile-merge-duplite-code-to-seq_open_private.patch avoid-negative-and-full-width-shifts-in-radix-treec.patch writeback-fix-time-ordering-of-the-per-superblock-inode-lists-8.patch writeback-fix-ntfs-with-sb_has_dirty_inodes.patch writeback-remove-pages_skipped-accounting-in-__block_write_full_page.patch writeback-remove-pages_skipped-accounting-in-__block_write_full_page-fix.patch writeback-introduce-writeback_controlmore_io-to-indicate-more-io.patch writeback-remove-unnecessary-wait-in-throttle_vm_writeout.patch