All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: reviewer's statement of oversight
Date: Mon, 8 Oct 2007 19:37:07 +0200	[thread overview]
Message-ID: <20071008173706.GA12026@uranus.ravnborg.org> (raw)
In-Reply-To: <25555.1191864285@lwn.net>

On Mon, Oct 08, 2007 at 11:24:45AM -0600, Jonathan Corbet wrote:
> Last month, at the kernel summit, there was discussion of putting a
> Reviewed-by: tag onto patches to document the oversight they had
> received on their way into the mainline.  That tag has made an
> occasional appearance since then, but there has not yet been a
> discussion of what it really means.  So it has not yet brought a whole
> lot of value to the process.
> 
> As I was trying to sleep last night, it occurred to me that what we
> might need is an equivalent of the DCO for the Reviewed-by tag.  To that
> end, I dedicated a few minutes of my life to the following bit of text.
> It's really just meant to be a starting point for the discussion.  Is
> the following something close to what we understand Reviewed-by to mean? 
> 
> jon
> 
> 
> Reviewer's statement of oversight v0.01
> 
> By offering my Reviewed-by: tag, I state that:

snip...

Or maybe we need something much less formal that explain the purpose of the
four tags we use:

Signed-of-by:
Acked-by:
Reviewed-by:
Cc:
Tested-by:

OK - make it five then. I continously to see people mixing up especially
Acked-by: and Signed-of-by: both here at lkml but especially at the
arm-kernel list (the only other Linux dev list I follow atm). I do
beleive we see similar pattern in the other linux-dev lists where
people are confused by these tags and need a short two line summery for 
each of them.

	Sam

  parent reply	other threads:[~2007-10-08 17:35 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 17:24 RFC: reviewer's statement of oversight Jonathan Corbet
2007-10-08 17:31 ` Pekka Enberg
2007-10-08 17:37 ` Sam Ravnborg [this message]
2007-10-08 17:45   ` Jan Engelhardt
2007-10-08 18:01     ` Jeremy Fitzhardinge
2007-10-08 18:06       ` Randy Dunlap
2007-10-08 18:16         ` Jeremy Fitzhardinge
2007-10-08 18:34         ` Stefan Richter
2007-10-08 18:52           ` J. Bruce Fields
2007-10-08 19:04             ` Stefan Richter
2007-10-08 19:26             ` Scott Preece
2007-10-08 20:16               ` Rafael J. Wysocki
2007-10-09  2:07                 ` Steven Rostedt
2007-10-09  6:11                   ` Stefan Richter
2007-10-09  6:27                     ` Sam Ravnborg
2007-10-09  6:39                       ` Stefan Richter
2007-10-09  6:47                         ` Stefan Richter
2007-10-08 18:26     ` Stefan Richter
2007-10-08 18:40     ` Roland Dreier
2007-10-08 19:35     ` Scott Preece
2007-10-08 20:33     ` H. Peter Anvin
2007-10-08 21:38       ` Theodore Tso
2007-10-08 22:18         ` Rafael J. Wysocki
2007-10-08 23:20         ` Oleg Verych
2007-10-08 22:43   ` Jonathan Corbet
2007-10-08 23:06     ` Randy Dunlap
2007-10-09  3:34       ` Stephen Hemminger
2007-10-08 23:30     ` J. Bruce Fields
2007-10-09 10:28       ` Alan Cox
2007-10-08 23:42     ` Stefan Richter
2007-10-09  0:05     ` Neil Brown
2007-10-09 16:49       ` Jonathan Corbet
2007-10-09 17:25         ` Roland Dreier
2007-10-10  0:06         ` David Chinner
2007-10-15  0:27           ` Neil Brown
2007-10-09 17:44       ` Sam Ravnborg
2007-10-15  0:35         ` Neil Brown
2007-10-15 14:32           ` Sam Ravnborg
2007-10-10 13:40     ` Scott Preece
2007-10-08 18:40 ` Mark Gross
2007-10-08 18:53   ` Stefan Richter
2007-10-08 19:05     ` Al Viro
2007-10-08 19:08       ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071008173706.GA12026@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.