From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: linux-ide@vger.kernel.org, gadio@netvision.net.il
Subject: Re: [PATCH] IDE: Remove inclusion of non-existent io_trace.h.
Date: Mon, 8 Oct 2007 22:38:08 +0200 [thread overview]
Message-ID: <200710082238.08931.bzolnier@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0710070748180.1286@localhost.localdomain>
Hi,
On Sunday 07 October 2007, Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> the fact that this header file doesn't exist has apparently been
> known for quite some time:
>
> http://osdir.com/ml/linux.tape/2005-07/msg00001.html
>
> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> index 1fa5794..e5a86a9 100644
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -621,7 +621,6 @@ typedef struct os_dat_s {
> */
> #define USE_IOTRACE 0
> #if USE_IOTRACE
> -#include <linux/io_trace.h>
> #define IO_IDETAPE_FIFO 500
> #endif
It seems that all code covered by #if/#endif USE_IOTRACE in ide-tape.c
could be removed as well. Care to respin the patch?
Thanks,
Bart
next prev parent reply other threads:[~2007-10-08 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-07 11:51 [PATCH] IDE: Remove inclusion of non-existent io_trace.h Robert P. J. Day
2007-10-08 20:38 ` Bartlomiej Zolnierkiewicz [this message]
2007-10-19 21:29 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710082238.08931.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=gadio@netvision.net.il \
--cc=linux-ide@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.