All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: rt2400-devel@lists.sourceforge.net
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Adam Baker <linux@baker-net.org.uk>,
	"Luis R. Rodriguez" <mcgrof@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [Rt2400-devel] Mode selection in mac80211
Date: Mon, 8 Oct 2007 23:08:38 +0200	[thread overview]
Message-ID: <200710082308.38260.IvDoorn@gmail.com> (raw)
In-Reply-To: <1191837339.4063.25.camel@johannes.berg>

> > Is it intended that the order of calling ieee80211_register_hwmode should 
> > determine which mode should be preferred when multiple modes exist on the 
> > same channel or is there either already or planned a better option for driver 
> > writers? If calling order should determine preference should it be first or 
> > last registered?
> 
> That's actually a can of worms. Luis is working (I hope) on resolving
> these issues with mode vs. frequency selection. However, I'm not
> entirely convinced that mode selection should be done by userspace when
> we are acting as a client. I think we should simply exploit hardware
> capabilities as much as possible and then use the set that the AP
> advertised (or rather as much as we can support of that).
> 
> Hence, for these questions it'd be good to know whether the ralink
> drivers do anything different based on the selected mode, and if they do
> (I assume they do because they register B *and* G modes) what it is.

The only difference currently in rt2x00 is for rt2500usb. The initialization
of the IFS and EIFS register is different.
I haven't gone through the legacy driver to see if there aren't any further
changes. But since I believe I have extracted all register initializations
that meant something from the legacy driver, this small difference can
probably be considered as the only thing.

> It'd probably help a lot with the design of the interface if you could
> answer that. I feel that mode selection should not be necessary since in
> G mode a device needs to have the capability to talk to B-only stations
> and hence must be able to "fall back" to B mode, we should therefore be
> able to exploit that capability without the driver ever registering
> different modes.

And is mac80211 doing that correctly at this time?
If so I could drop the 802.11B mode registration if that is the preferred action.

> In fact, I think that the driver can probably simply register the
> modulations/bitrates it can support orthogonally to the frequencies it
> supports, and the frequencies consist of only information about the
> frequency and possibly hardware value used to select it. This was part
> of what I posted a while ago when Luis was posting his regulatory stuff,
> and I think should be addressed while cleaning up that whole mess.

Only registering the supported rates and channels and let mac80211 sort
out the modes itself does sound like a good idea. :)

Ivo

  parent reply	other threads:[~2007-10-08 20:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-05 22:19 Mode selection in mac80211 Adam Baker
2007-10-08  9:55 ` Johannes Berg
2007-10-08 10:23   ` [PATCH] mac80211: fix set_channel regression Johannes Berg
2007-10-08 14:32   ` Mode selection in mac80211 Mike Kershaw
2007-10-09  9:21     ` Johannes Berg
2007-10-09 13:55       ` Mike Kershaw
2007-10-09 17:06         ` Johannes Berg
2007-10-08 21:08   ` Ivo van Doorn [this message]
2007-10-09  9:20     ` [Rt2400-devel] " Johannes Berg
2007-10-09 14:27       ` Ivo van Doorn
2007-10-09 17:05         ` Johannes Berg
2007-10-09 17:32           ` Ivo van Doorn
2007-10-09 17:29             ` Johannes Berg
2007-10-09 17:54               ` Ivo van Doorn
2007-10-09 17:40                 ` Johannes Berg
2007-10-09 18:18                   ` Ivo van Doorn
2007-10-09 18:05                     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710082308.38260.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@baker-net.org.uk \
    --cc=mcgrof@gmail.com \
    --cc=rt2400-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.