From: David Chinner <dgc@sgi.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] Ensure sync flushes all dirty data to disk]
Date: Tue, 9 Oct 2007 18:54:12 +1000 [thread overview]
Message-ID: <20071009085412.GT23367404@sgi.com> (raw)
In-Reply-To: <470B2EEC.5020906@sgi.com>
On Tue, Oct 09, 2007 at 05:34:04PM +1000, Lachlan McIlroy wrote:
> [V2 adds a comment for dgc]
>
> In xfs_fs_sync_super() treat a sync the same as a filesystem freeze.
> This is needed to force the log to disk for inodes which are not marked
> dirty in the Linux inode (the inodes are marked dirty on completion of
> the log I/O) and so sync_inodes() will not flush them.
>
> In xfs_fs_write_inode() a synchronous flush will not get an EAGAIN
> from xfs_inode_flush() and if an asynchronous flush returns EAGAIN
> we should pass it on to the caller. If we get an error while flushing
> the inode then re-dirty it so we can try again later.
Looks good now, Lachlan.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2007-10-09 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 7:34 [PATCH V2] Ensure sync flushes all dirty data to disk] Lachlan McIlroy
2007-10-09 8:54 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009085412.GT23367404@sgi.com \
--to=dgc@sgi.com \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.