From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH] Save some bytes in scsi_cmnd by rearranging members Date: Tue, 9 Oct 2007 06:08:48 -0600 Message-ID: <20071009120848.GC13842@parisc-linux.org> References: <20071008235010.GZ12049@parisc-linux.org> <470B4D13.8000705@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:53751 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbXJIMIt (ORCPT ); Tue, 9 Oct 2007 08:08:49 -0400 Content-Disposition: inline In-Reply-To: <470B4D13.8000705@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Boaz Harrosh Cc: linux-scsi@vger.kernel.org On Tue, Oct 09, 2007 at 11:42:43AM +0200, Boaz Harrosh wrote: > Please don't do this patch for now. This is because of the > soon to come scsi_data_buffer patch that rearages most of the members above > and puts them in a substructure. Maybe after the scsi_data_buffer patch you can > try to do this again. Need to be careful with sub-structures. They can cause more waste; for example scsi_pointer (on 64-bit) has 4 bytes wasted at the end that can't be filled when it's embedded into the scsi_cmnd. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."