From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH-RESUBMIT] net/netfilter/x_tables.c unnecessary casts
Date: Tue, 09 Oct 2007 19:32:38 +0000 [thread overview]
Message-ID: <20071009193238.GC11579@Ahmed> (raw)
In-Reply-To: <3ed55890709110649n29c98a10j7f1479aeda368f11@mail.gmail.com>
On Wed, Sep 19, 2007 at 09:32:56AM +0200, Liran Tal wrote:
>
> The patch removes an unnecessary cast in accordance to the rest of
> the code. Kernel version is 2.6.22 with latest patches.
>
> The spaces that appeared before have been replaced with tabs,
> hopefully this version of the patch is compliant.
>
> Signed-off-by: Liran Tal <liran.tal@gmail.com>
>
> --- linux/net/netfilter/x_tables.c.orig 2007-09-11 11:21:44.000000000 +0300
> +++ linux/net/netfilter/x_tables.c 2007-09-11 11:22:11.000000000 +0300
> @@ -691,7 +691,7 @@ static struct list_head *type2list(u_int
>
> static void *xt_tgt_seq_start(struct seq_file *seq, loff_t *pos)
> {
> - struct proc_dir_entry *pde = (struct proc_dir_entry *) seq->private;
> + struct proc_dir_entry *pde = seq->private;
> u_int16_t af = (unsigned long)pde->data & 0xffff;
> u_int16_t type = (unsigned long)pde->data >> 16;
> struct list_head *list;
>
Patch was applied with no problems. Just some minor notes:
1- a "---" string below the Signed-off-by line
2- Take care that most of the sentences above the signed-off-by line are
written in the git logs. so don't put unwanted text.
3- you can write any info that's not appropriate for the logs under the
"---" line and before the patch (like the kernel version).
That's all :).
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
_______________________________________________
REMINDER: this mailing list moved to vger.kernel.org and current one will be discontinued soon.
To resubscribe, send email to majordomo@vger.kernel.org with
"subscribe kernel-janitors" in message body and follow instructions.
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2007-10-09 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 13:49 [KJ] [PATCH-RESUBMIT] net/netfilter/x_tables.c unnecessary casts liran tal
2007-09-11 15:17 ` Randy Dunlap
2007-09-11 16:06 ` liran tal
2007-09-11 16:53 ` liran tal
2007-09-11 19:44 ` Randy Dunlap
2007-09-12 6:19 ` liran tal
2007-09-12 15:25 ` Randy Dunlap
2007-09-17 12:37 ` Liran Tal
2007-09-19 7:32 ` Liran Tal
2007-10-09 19:32 ` Ahmed S. Darwish [this message]
2007-10-09 19:43 ` liran tal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009193238.GC11579@Ahmed \
--to=darwish.07@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.