All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Fix warning in gpio.c
Date: Tue, 9 Oct 2007 15:18:20 -0700	[thread overview]
Message-ID: <20071009221819.GD4151@atomide.com> (raw)
In-Reply-To: <47034031.7010004@googlemail.com>

* Dirk Behme <dirk.behme@googlemail.com> [071003 00:11]:
>
> Fix warning
>
> arch/arm/plat-omap/gpio.c: In function '_omap_gpio_init':
> arch/arm/plat-omap/gpio.c:1299: warning: unused variable 'clk_name'
> arch/arm/plat-omap/gpio.c: At top level:
> arch/arm/plat-omap/gpio.c:1282: warning: 'gpio_fck' defined but not used
>
> for OMAP1.
>
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>

> Index: linux-osk/arch/arm/plat-omap/gpio.c
> ===================================================================
> --- linux-osk.orig/arch/arm/plat-omap/gpio.c
> +++ linux-osk/arch/arm/plat-omap/gpio.c
> @@ -1277,8 +1277,11 @@ static inline void mpuio_init(void) {}
>  /*---------------------------------------------------------------------*/
>  
>  static int initialized;
> -#if !defined(CONFIG_ARCH_OMAP34XX)
> +#if !defined(CONFIG_ARCH_OMAP3)
>  static struct clk * gpio_ick;
> +#endif
> +
> +#if defined(CONFIG_ARCH_OMAP2)
>  static struct clk * gpio_fck;
>  #endif
>  
> @@ -1296,7 +1299,9 @@ static int __init _omap_gpio_init(void)
>  {
>  	int i;
>  	struct gpio_bank *bank;
> +#if defined(CONFIG_ARCH_OMAP3)
>  	char clk_name[11];
> +#endif
>  
>  	initialized = 1;
>  

Pushing today.

Tony

      reply	other threads:[~2007-10-09 22:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-03  7:09 [PATCH] ARM: OMAP: Fix warning in gpio.c Dirk Behme
2007-10-09 22:18 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071009221819.GD4151@atomide.com \
    --to=tony@atomide.com \
    --cc=dirk.behme@googlemail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.