From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: [PATCH] ACPI: idle: delete access to ACPI_BITREG_BUS_MASTER_RLD Date: Wed, 10 Oct 2007 00:05:55 -0400 Message-ID: <200710100005.56059.lenb@kernel.org> References: <200710040053.04489.lenb@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:39944 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbXJJEGL (ORCPT ); Wed, 10 Oct 2007 00:06:11 -0400 Received: from d975xbx2 (c-65-96-213-102.hsd1.ma.comcast.net [65.96.213.102]) (authenticated bits=0) by hera.kernel.org (8.13.8/8.13.8) with ESMTP id l9A461PN030981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 10 Oct 2007 04:06:05 GMT In-Reply-To: <200710040053.04489.lenb@kernel.org> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: ACPI Devel Maling List I've been told that BM_RLD is not a NOP in the PIIX4 - ICH4-M generations; and that those chips follow the 1st description in the ACPI spec, not the second. (I've also submitted a bug against the ACPI spec:-) So the patch below is no good. But the old code still isn't quite right. It seems we should just set BM_RLD at initialization and forget about it rather than monkeying with it at run-time. cheers, -Len On Thursday 04 October 2007 00:53, Len Brown wrote: > From: Len Brown > > The ACPI specification describes PM1*_CNT_BLK.BM_RLD in two places. > > The first description says that the OS needs to set BM_RLD > to enable bus master activity to wake the processor from C3. > > The second description says that the platform sets BM_RLD > to indicate whether it was bus master activity that woke the > platform from C3 or not. > > The first description is erroneous, the second description is correct. > Delete Linux's implementation of the first description. > > Signed-off-by: Len Brown > > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index f182613..4f004f1 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -192,26 +192,6 @@ acpi_processor_power_activate(struct acpi_processor *pr, > old->promotion.count = 0; > new->demotion.count = 0; > > - /* Cleanup from old state. */ > - if (old) { > - switch (old->type) { > - case ACPI_STATE_C3: > - /* Disable bus master reload */ > - if (new->type != ACPI_STATE_C3 && pr->flags.bm_check) > - acpi_set_register(ACPI_BITREG_BUS_MASTER_RLD, 0); > - break; > - } > - } > - > - /* Prepare to use new state. */ > - switch (new->type) { > - case ACPI_STATE_C3: > - /* Enable bus master reload */ > - if (old->type != ACPI_STATE_C3 && pr->flags.bm_check) > - acpi_set_register(ACPI_BITREG_BUS_MASTER_RLD, 1); > - break; > - } > - > pr->power.state = new; > > return; > @@ -1027,7 +1007,6 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr, > " for C3 to be enabled on SMP systems\n")); > return; > } > - acpi_set_register(ACPI_BITREG_BUS_MASTER_RLD, 0); > } > > /* >