All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Introduce ext4_inoblk_t
Date: Tue, 9 Oct 2007 20:48:11 -0400	[thread overview]
Message-ID: <20071010004811.GO31713@thunk.org> (raw)
In-Reply-To: <1191945972-11403-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

On Tue, Oct 09, 2007 at 09:36:12PM +0530, Aneesh Kumar K.V wrote:
> This patch adds a new data type ext4_inoblk_t to represent
> the logical file blocks.

I'd suggest ext4_lblk_t instead of ext4_inoblk_t.  It's not at all
obvious what "inode block" means.  "Logical block" makes a lot more
sense.

Personally, I was never synced with ext4_fsblk_t myself; I think
ext4_pblk_t would make a lot more sense.

	    	       	     	  - Ted

      reply	other threads:[~2007-10-10  0:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09 16:06 [PATCH] ext4: Introduce ext4_inoblk_t Aneesh Kumar K.V
2007-10-10  0:48 ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071010004811.GO31713@thunk.org \
    --to=tytso@mit.edu \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.