All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Steffen Prohaska <prohaska@zib.de>
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: [PATCH v2] git-gui: add mingw specific startup wrapper
Date: Wed, 10 Oct 2007 04:02:56 -0400	[thread overview]
Message-ID: <20071010080256.GR2137@spearce.org> (raw)
In-Reply-To: <11919995392881-git-send-email-prohaska@zib.de>

Steffen Prohaska <prohaska@zib.de> wrote:
> The wrapper adds the directory it is installed in to PATH.
> This is required for the git commands implemented in shell.
> git-gui fails to launch them if PATH is not modified.

Thanks, I have both of these applied now to master and will push
it out shortly, along with the mingw version fix you had sent
me much earlier.
 
> +if { $argc >=2 && [lindex $argv 0] == "--working-dir" } {
> +	cd [lindex $argv 1]
> +	set argv [lrange $argv 2 end]
> +	incr argc -2
> +}

Perhaps someday in the future we'll put this into git-gui.sh so
all platforms can use it.  Today, its Windows only.  ;-)

-- 
Shawn.

  reply	other threads:[~2007-10-10  8:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071010053728.GM2137@spearce.org>
2007-10-10  5:56 ` [PATCH] git-gui: add mingw specific startup wrapper Steffen Prohaska
2007-10-10  6:22   ` Shawn O. Pearce
2007-10-10  6:55     ` Steffen Prohaska
2007-10-10  6:58       ` [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit Steffen Prohaska
2007-10-10  6:58         ` [PATCH v2] git-gui: add mingw specific startup wrapper Steffen Prohaska
2007-10-10  8:02           ` Shawn O. Pearce [this message]
2007-10-10 15:56           ` Johannes Schindelin
2007-10-10 16:10             ` Steffen Prohaska
2007-10-10 15:52         ` [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit Johannes Schindelin
2007-10-10 15:58           ` Steffen Prohaska
2007-10-10 19:46             ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071010080256.GR2137@spearce.org \
    --to=spearce@spearce.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=prohaska@zib.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.