All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Make m68k cross compile like every other architecture.
Date: Wed, 10 Oct 2007 17:22:21 -0500	[thread overview]
Message-ID: <200710101722.21126.rob@landley.net> (raw)

From: Rob Landley <rob@landley.net>

Rip out hardwired cross compiler name assumption that only m68k makes.

Signed-off-by: Rob Landley <rob@landley.net>
---
When you cross compile, you have to set the prefix CROSS_COMPILE to your
cross compiler prefix.  You need to do this for all targets (arm, mips, ppc,
x86-64 on x86, etc).  This is not specific to m68k, and this value is
supplied _to_ the build, not supplied _by_ the build.

The build shouldn't unconditionally overwrite the existing value of this
variable with one it makes up.  It has no idea what I called my cross compiler.

 arch/m68k/Makefile |    7 -------
 1 file changed, 7 deletions(-)

diff -r 79f0ea1e0e70 arch/m68k/Makefile
--- a/arch/m68k/Makefile	Tue Oct 09 21:00:40 2007 +0000
+++ b/arch/m68k/Makefile	Wed Oct 10 17:02:17 2007 -0500
@@ -13,17 +13,10 @@
 # Copyright (C) 1994 by Hamish Macdonald
 #
 
-# test for cross compiling
-COMPILE_ARCH = $(shell uname -m)
-
 # override top level makefile
 AS += -m68020
 LDFLAGS := -m m68kelf
 LDFLAGS_MODULE += -T $(srctree)/arch/m68k/kernel/module.lds
-ifneq ($(COMPILE_ARCH),$(ARCH))
-	# prefix for cross-compiling binaries
-	CROSS_COMPILE = m68k-linux-gnu-
-endif
 
 ifdef CONFIG_SUN3
 LDFLAGS_vmlinux = -N

-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

             reply	other threads:[~2007-10-10 22:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10 22:22 Rob Landley [this message]
2007-10-11  7:25 ` [PATCH] Make m68k cross compile like every other architecture Geert Uytterhoeven
2007-10-11 11:31   ` Rob Landley
2007-10-11 11:39   ` Sam Ravnborg
2007-10-11 12:46     ` Geert Uytterhoeven
2007-10-11 13:27       ` Rob Landley
2007-10-11 13:52         ` Paul Mundt
2007-10-11 15:12         ` Geert Uytterhoeven
2007-10-11 16:26           ` Finn Thain
2007-10-11 21:14             ` Rob Landley
2007-10-12  6:51               ` Geert Uytterhoeven
2007-10-12  7:54                 ` Finn Thain
2007-10-12  8:51                   ` Geert Uytterhoeven
2007-10-12 10:21                     ` Sam Ravnborg
2007-10-15 20:25                       ` Geert Uytterhoeven
2007-10-16  0:31                         ` Rob Landley
2007-10-16  4:15                           ` Sam Ravnborg
2007-10-18 21:14                         ` Sam Ravnborg
2007-10-19  6:38                           ` Rob Landley
2007-10-19 15:10                             ` Sam Ravnborg
2007-10-11 16:24       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710101722.21126.rob@landley.net \
    --to=rob@landley.net \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.