From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Thomas Renninger <trenn@suse.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org,
Len Brown <lenb@kernel.org>
Subject: Re: [ibm-acpi-devel] How to distinguish between general ACPI video driver module and brightness/display providing vendor specific ACPI modules
Date: Wed, 10 Oct 2007 18:23:32 -0300 [thread overview]
Message-ID: <20071010212332.GC509@khazad-dum.debian.net> (raw)
In-Reply-To: <20071010204632.GA509@khazad-dum.debian.net>
On Wed, 10 Oct 2007, Henrique de Moraes Holschuh wrote:
> > 3)
> > I think I found a bug in thinkpad_acpi:
> > if (!*ibm->acpi->handle)
> > return 0;
> > in setup_acpi_notify(..) probably should be:
> > if (!ibm->acpi->handle)
> > return 0;
>
> I will check that.
No bug there. handle is a pointer to the handle, so it has to be
dereferenced.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2007-10-10 21:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 13:12 [GIT PATCH v2] thinkpad-acpi changes for the merge window (part 2) Henrique de Moraes Holschuh
2007-10-08 13:12 ` [PATCH 2/4] ACPI: thinkpad-acpi: support 16 levels of brightness (v2) Henrique de Moraes Holschuh
2007-10-09 5:16 ` [ibm-acpi-devel] " Thomas Renninger
[not found] ` <1191907013.9847.69.camel-X8wR35IVlAxolqkO4TVVkw@public.gmane.org>
2007-10-09 11:45 ` Henrique de Moraes Holschuh
[not found] ` <1191849179-24087-1-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-10-08 13:12 ` [PATCH 1/4] ACPI: thinkpad-acpi: skip blanks before the data when parsing sysfs Henrique de Moraes Holschuh
2007-10-08 13:12 ` [PATCH 3/4] ACPI: thinkpad-acpi: disable backlight handler if ACPI generic could do it Henrique de Moraes Holschuh
2007-10-09 6:21 ` Thomas Renninger
[not found] ` <1191910875.9847.79.camel-X8wR35IVlAxolqkO4TVVkw@public.gmane.org>
2007-10-09 7:59 ` Matthew Garrett
2007-10-09 8:25 ` Thomas Renninger
2007-10-09 8:33 ` Matthew Garrett
2007-10-09 9:46 ` Thomas Renninger
2007-10-09 10:04 ` Matthew Garrett
2007-10-09 11:14 ` Henrique de Moraes Holschuh
2007-10-09 13:29 ` Thomas Renninger
2007-10-09 13:34 ` Matthew Garrett
2007-10-09 13:47 ` Thomas Renninger
2007-10-09 13:49 ` Matthew Garrett
2007-10-09 13:47 ` Henrique de Moraes Holschuh
2007-10-09 14:11 ` Thomas Renninger
2007-10-09 14:29 ` Henrique de Moraes Holschuh
2007-10-09 20:53 ` How to distinguish between general ACPI video driver module and brightness/display providing vendor specific ACPI modules Thomas Renninger
2007-10-10 11:44 ` [ibm-acpi-devel] " Thomas Renninger
2007-10-10 20:46 ` Henrique de Moraes Holschuh
2007-10-10 21:23 ` Henrique de Moraes Holschuh [this message]
2007-10-08 13:12 ` [PATCH 4/4] ACPI: thinkpad-acpi: bump up version to 0.17 Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010212332.GC509@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.