From: Andrew Morton <akpm@linux-foundation.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>
Subject: Re: drivers/fc4/fc.c in git-scsi-misc
Date: Thu, 11 Oct 2007 11:20:58 -0700 [thread overview]
Message-ID: <20071011112058.d95fe040.akpm@linux-foundation.org> (raw)
In-Reply-To: <470E037C.4080204@panasas.com>
On Thu, 11 Oct 2007 13:05:32 +0200 Boaz Harrosh <bharrosh@panasas.com> wrote:
> On Thu, Oct 11 2007 at 11:52 +0200, Andrew Morton <akpm@linux-foundation.org> wrote:
> > davem won't be happy
> >
> > drivers/fc4/fc.c: In function `fcp_scsi_receive':
> > drivers/fc4/fc.c:397: error: structure has no member named `done'
> > drivers/fc4/fc.c:450: error: structure has no member named `done'
> > drivers/fc4/fc.c: In function `fcp_scsi_queuecommand':
> > drivers/fc4/fc.c:837: error: structure has no member named `done'
> > drivers/fc4/fc.c:838: error: structure has no member named `done'
> > drivers/fc4/fc.c:839: error: structure has no member named `done'
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> OK that was a nice lesson in Kconfig and Linux-Makefile for me :)
>
> So I can see that drivers/fc4/Kconfig is only "source"d from
> arch/sparc64/Kconfig. Hence no one experienced the breakage.
>
> [
> If I add to, say, drivrs/Kconfig
> +source drivers/fc4/Kconfig
> Than everything compiles and I can see the breakage now
> ]
Well if fc4.c compiles OK on non-sparc64 then perhaps we should enable
compilation on non-sparc64. It will increase maintainability and code
quality and stuff.
otoh people might end up shipping useless drivers in x86 distros.
> Do you have a cross-compiling environment to compile all these
> ARCHs, or you actually have these machines laying around for
> compilation. (It's the cross-compiling I'm interested in)
There are a number of precompiled (by me) cross-compilers at
http://userweb.kernel.org/~akpm/cross-compilers/
next prev parent reply other threads:[~2007-10-11 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 9:52 drivers/fc4/fc.c in git-scsi-misc Andrew Morton
2007-10-11 11:05 ` Boaz Harrosh
2007-10-11 18:20 ` Andrew Morton [this message]
2007-10-12 0:38 ` David Miller
2007-10-12 18:04 ` James Bottomley
2007-10-12 22:25 ` David Miller
2007-10-13 17:34 ` Matthew Wilcox
2007-10-11 12:03 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011112058.d95fe040.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@steeleye.com \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.