From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ifyc1-0003ik-01 for mharc-grub-devel@gnu.org; Thu, 11 Oct 2007 10:02:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ifyby-0003gP-Tx for grub-devel@gnu.org; Thu, 11 Oct 2007 10:02:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ifybx-0003es-Mt for grub-devel@gnu.org; Thu, 11 Oct 2007 10:02:02 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ifybx-0003ea-FX for grub-devel@gnu.org; Thu, 11 Oct 2007 10:02:01 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ifybx-0003em-0a for grub-devel@gnu.org; Thu, 11 Oct 2007 10:02:01 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Ifybv-0006Jp-48 for grub-devel@gnu.org; Thu, 11 Oct 2007 16:01:59 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IfybX-0005G7-Sb for grub-devel@gnu.org; Thu, 11 Oct 2007 16:01:35 +0200 Date: Thu, 11 Oct 2007 16:01:35 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071011140135.GA19873@thorin> References: <20071001123345.GB20428@thorin> <8a2a06bb0710011114l5cc66483vc27b0b83eb3395e1@mail.gmail.com> <20071001183927.GA10233@thorin> <8a2a06bb0710011243m38ac71a0t463b6ea56ff19e78@mail.gmail.com> <20071002213942.GC29487@thorin> <8a2a06bb0710031633v55549654v9184c3a460c202f5@mail.gmail.com> <20071004205038.GB23726@thorin> <8a2a06bb0710100811m41e08028t2404090a4d9a91b9@mail.gmail.com> <20071010191910.GA26777@thorin> <8a2a06bb0710101457g5b3e4a19v65025a0e017f3d73@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a2a06bb0710101457g5b3e4a19v65025a0e017f3d73@mail.gmail.com> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fixed ieee1275 console X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2007 14:02:03 -0000 On Wed, Oct 10, 2007 at 11:57:44PM +0200, Marcin Kurek wrote: > > In your code there's a condition in which _serial is set to 0 and _fb is > > left unset (as 0). Is this intended? Sounds like a bug. > > Not this is not a bug. We can heve 3 cases here: > > 1) True serial console. In this case recent versions of OF set stdout > name and type to "serial" (_serial = 1, _fb = 0) In this case we want > to use simple frames. > > 2) On the screen terminal without framebuffer (fb-mode not existing or > set to 0x0x0) In this case we will get type "serial" (As it not > supports pixel operations) and name "display" as this is not real > serial console. (_serial = 0, _fb = 0) In this case we can use cp437 > frames. > > For old versions of OF this case need to catch "bootconsole" too. > > 3) Console with framebuffer (fb-mode != 0x0x0) In this case we will > get type to "display" or "vga" (_serial = 0, _fb = 1) In this case we > can not use cp437 frames as vga font used by OF maps only first 127 > characters ;( I put this in to separate case as we can still use > framebuffer interface to draw some frames or try to load a working > font, etc. > > I use 'true serial' as a safe default if detection fails for some reasons. Ok but do we really need to make that distinction? Perhaps it would be simpler to define a structure that only cares about charset capability, and make code that plays with charsets just check that, without caring if it's a serial cable or a vga with old firmware, etc. And possibly this could be integrated with your proposed use of grub_term.flags ? (I'm not sure if that would make sense, but it would be nice to simplify if possible) -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)