From: David Gibson <dwg@au1.ibm.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH 4/4 v2] [POWERPC] Kilauea defconfig file
Date: Fri, 12 Oct 2007 13:23:44 +1000 [thread overview]
Message-ID: <20071012032344.GG21056@localhost.localdomain> (raw)
In-Reply-To: <1192137219.3061.2.camel@localhost.localdomain>
On Thu, Oct 11, 2007 at 04:13:39PM -0500, Josh Boyer wrote:
> On Thu, 2007-10-11 at 15:12 -0500, Scott Wood wrote:
> > On Thu, Oct 11, 2007 at 03:31:12PM +0200, Stefan Roese wrote:
> > > Yes, good catch. Since I'm not using the bootwrapper, I should be able to get
> > > rid of WANT_DEVICE_TREE too. But it seems to be autoselected in
> > > arch/powerpc/platforms/Kconfig.cputype for 40x and most other "embedded"
> > > CPU's. Any idea why this is the case?
> >
> > Probably copying from 83xx, 85xx, etc, which set it on the entire CPU family
> > because there's a wrapper platform that covers the entire family. AFAICT,
> > there are only board wrappers for 4xx, so individual boards should be
> > selecting WANT_DEVICE_TREE.
>
> Probably. Seems somewhat redundant at this point to move it into the
> individual board options though.
>
> > In any case, you can just set DEVICE_TREE to an empty string if you only
> > want the regular uImage.
>
> Well, he wants the raw uImage, and a separate DTB to be spit out as far
> as I can tell. So we don't want an empty string here, but what's there
> currently doesn't do the latter part either.
I think it should be DEVICE_TREE="kilauea.dts". DEVICE_TREE will
actually be ignored for building the uImage in any case, but this way
it will be correct if we ever do add a cuboot or other dtb-requiring
bootwrapper for Kilauea.
This is, of course, why CONFIG_DEVICE_TREE makes no real sense and
never has: it's a per-image, not a per-configuration variable.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-10-12 3:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 12:08 [PATCH 4/4 v2] [POWERPC] Kilauea defconfig file Stefan Roese
2007-10-11 13:02 ` Josh Boyer
2007-10-11 13:31 ` Stefan Roese
2007-10-11 15:37 ` Wolfgang Denk
2007-10-11 16:39 ` Josh Boyer
2007-10-11 20:12 ` Scott Wood
2007-10-11 21:13 ` Josh Boyer
2007-10-12 3:23 ` David Gibson [this message]
2007-10-12 15:20 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071012032344.GG21056@localhost.localdomain \
--to=dwg@au1.ibm.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.