From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IgMrQ-0006cZ-Bg for mharc-grub-devel@gnu.org; Fri, 12 Oct 2007 11:55:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IgMrP-0006bb-KA for grub-devel@gnu.org; Fri, 12 Oct 2007 11:55:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IgMrN-0006Y5-VC for grub-devel@gnu.org; Fri, 12 Oct 2007 11:55:35 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IgMrN-0006Xv-Pq for grub-devel@gnu.org; Fri, 12 Oct 2007 11:55:33 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IgMrN-00084h-KO for grub-devel@gnu.org; Fri, 12 Oct 2007 11:55:33 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IgMrH-0000BR-PZ for grub-devel@gnu.org; Fri, 12 Oct 2007 17:55:28 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IgMqt-0006ij-OT for grub-devel@gnu.org; Fri, 12 Oct 2007 17:55:03 +0200 Date: Fri, 12 Oct 2007 17:55:03 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071012155503.GA25660@thorin> References: <20071001145354.GA1483@thorin> <20071011225845.GA3512@thorin> <87r6k0vc3p.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r6k0vc3p.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] generic ELF version of grub-mkimage X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2007 15:55:35 -0000 On Fri, Oct 12, 2007 at 12:52:42PM +0200, Marco Gerards wrote: > > 2007-10-12 Robert Millan > > > > * conf/powerpc-ieee1275.rmk (grub_mkimage_SOURCES): Replace reference > > to util/powerpc/ieee1275/grub-mkimage.c with util/elf/grub-mkimage.c. > > > > * include/grub/types.h (#ifdef GRUB_CPU_WORDS_BIGENDIAN): Define > > grub_host_to_target16, grub_host_to_target32, grub_host_to_target64, > > grub_target_to_host16, grub_target_to_host32 and grub_target_to_host64. > > (#else): Likewise. > > This syntax is wrong. It should have been something like: > > > * include/grub/types.h (#ifdef GRUB_CPU_WORDS_BIGENDIAN): Define > > grub_host_to_target16, grub_host_to_target32, grub_host_to_target64, > > grub_target_to_host16, grub_target_to_host32 and grub_target_to_host64. > > (#else): Likewise. > > * include/grub/types.h (grub_host_to_target16): New macro. > (grub_host_to_target32): Likewise. > > etc... Ok. > If you are not sure, better wait a few days before committing a > patch. Or ask me to double check it. I *was* sure. I just happen to be not very good at learning a particular ChangeLog style. > > * include/grub/powerpc/ieee1275/kernel.h (GRUB_IEEE1275_MOD_ALIGN): > > Renamed from to ... > > (GRUB_MOD_ALIGN): ...this. Update all users. > > > > * util/elf/grub-mkimage.c: Replace grub_cpu_to_be16, grub_cpu_to_be32, > > grub_be_to_cpu16 and grub_be_to_cpu32 macros with grub_host_to_target16, > > grub_host_to_target32, grub_target_to_host16 and grub_target_to_host32, > > respectively. > > You know quite well that this is wrong. You have to mention which > function you changed. Ok. But no, I didn't really notice. I'll fix this entry and keep trying to get it right next time. > If you use diff -up this is easy to see from the patch. Sounds very useful, thanks. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)