From: Sam Ravnborg <sam@ravnborg.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Franck Bui-Huu <vagabon.xyz@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-arch@vger.kernel.org, linux-mips@linux-mips.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Discardable strings for init and exit sections
Date: Fri, 12 Oct 2007 19:45:07 +0200 [thread overview]
Message-ID: <20071012174507.GA21193@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64N.0710121711120.21684@blysk.ds.pg.gda.pl>
On Fri, Oct 12, 2007 at 05:50:01PM +0100, Maciej W. Rozycki wrote:
> We currently have infrastructure for discardable text and data, but no
> such thing for strings. This is especially notable for inline strings
> such as ones used by printk() which are left behind resident in the memory
> throughout the life of the system even though code referring to them has
> been removed.
What is the actual benefit here expressed in real numbers?
For the __init/__exit notation that is yet only partially correct
we often see corner cases where one ask if it is really worth it.
Adding the discard functionality for strings seems like a logical extension
but there is a benefit/pain ratio to consider.
So real numbers please.
A few general notes to the patch.
1) We want to consolidate this in include/asm-generic/vmlinux*
somehow and this should be doen as a separate step.
2) If we introduce discardable strings then we shall in parallel
add build time checks so we catch strings marked as discardable
which is used outside a discardable compatible function.
Sam
next prev parent reply other threads:[~2007-10-12 17:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 16:50 [PATCH] Discardable strings for init and exit sections Maciej W. Rozycki
2007-10-12 17:19 ` Adrian Bunk
2007-10-12 17:52 ` Ralf Baechle
2007-10-12 18:15 ` Adrian Bunk
2007-10-23 16:57 ` Maciej W. Rozycki
2007-10-23 17:12 ` Adrian Bunk
2007-10-23 17:25 ` Sam Ravnborg
2007-10-12 17:45 ` Sam Ravnborg [this message]
2007-10-23 17:23 ` Maciej W. Rozycki
2007-10-23 17:27 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071012174507.GA21193@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.