All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Vlasenko <vda.linux@googlemail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: David Miller <davem@davemloft.net>,
	akpm@linux-foundation.org, netdev@vger.kernel.org,
	sam@ravnborg.org, benh@kernel.crashing.org
Subject: Re: net-2.6.24 breaks powerpc mysteriously
Date: Sun, 14 Oct 2007 04:43:46 +0100	[thread overview]
Message-ID: <200710140443.46788.vda.linux@googlemail.com> (raw)
In-Reply-To: <18190.62351.950590.493322@cargo.ozlabs.ibm.com>

On Friday 12 October 2007 05:09, Paul Mackerras wrote:
> > I supposed a hacky fix is to add __KERNEL__ ifdef protection around
> > zlib_inflate_blob() and those troublesome includes.  A nicer fix is
> 
> That would do, but I don't see why zlib_inflate_blob had to be added
> to inflate.c rather than being in a new file under lib/zlib_inflate.

Done.

> If nothing else, that bloats configs that currently use inflate.c (in
> the kernel) but don't need zlib_inflate_blob() - which would be all
> the existing uses. :)

I did it.

However, in general I prefer to have a better linker, one which
is capable of eliminate unused fuctions/data on the per-object basis,
not per .o file.

Patches to implement that are sent to Sam Ravnborg.
Hopefully they will make it to mainline.
--
vda

  reply	other threads:[~2007-10-14  3:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  2:22 net-2.6.24 breaks powerpc mysteriously Andrew Morton
2007-10-12  2:45 ` David Miller
2007-10-12  4:09   ` Paul Mackerras
2007-10-14  3:43     ` Denys Vlasenko [this message]
2007-10-14  3:40   ` Denys Vlasenko
2007-10-14  4:12     ` David Miller
2007-10-12  3:52 ` Paul Mackerras
2007-10-12  4:25   ` Andrew Morton
2007-10-12  4:54     ` David Miller
2007-10-12  5:18       ` David Miller
2007-10-12  5:47         ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710140443.46788.vda.linux@googlemail.com \
    --to=vda.linux@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.