Re: [patch] ssb: fix build failure

[Randy Dunlap <randy.dunlap@oracle.com>]

On Mon, 15 Oct 2007 16:23:04 +0200 Michael Buesch wrote:

> From: Ingo Molnar <mingo@elte.hu>
> 
> fix build failure if PCMCIA=m but SSB=y:
> 
> drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
> : undefined reference to `pcmcia_access_configuration_register'
> 
> (fix symmetric bug for PCI too.)
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> 
> ---
>  drivers/ssb/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux/drivers/ssb/Kconfig
> ===================================================================
> --- linux.orig/drivers/ssb/Kconfig
> +++ linux/drivers/ssb/Kconfig
> @@ -22,7 +22,7 @@ config SSB
>  
>  config SSB_PCIHOST_POSSIBLE
>  	bool
> -	depends on SSB && PCI
> +	depends on SSB && (PCI = SSB)
>  	default y
>  
>  config SSB_PCIHOST
> @@ -37,7 +37,7 @@ config SSB_PCIHOST
>  
>  config SSB_PCMCIAHOST_POSSIBLE
>  	bool
> -	depends on SSB && PCMCIA && EXPERIMENTAL
> +	depends on SSB && (PCMCIA = SSB) && EXPERIMENTAL
>  	default y
>  
>  config SSB_PCMCIAHOST

That's usually done more like this:

	depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL

This allows PCMCIA to be y or m, but if PCMCIA is m, then
SSB is restricted to m as well (or n).
I.e., PCMCIA = SSB is too strict and not required.

or am I not seeing straight?

---
~Randy