From: Masahide NAKAMURA <nakam@linux-ipv6.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Noriaki TAKAMIYA <takamiya@po.ntts.co.jp>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use
Date: Mon, 15 Oct 2007 11:45:10 +0900 [thread overview]
Message-ID: <20071015113723.00F7.NAKAM@linux-ipv6.org> (raw)
In-Reply-To: <20071014175212.GP4211@stusta.de>
On Sun, 14 Oct 2007 19:52:12 +0200
Adrian Bunk <bunk@kernel.org> wrote:
> The Coverity checker spotted that we have already oops'ed if "dst"
> was NULL.
>
> Since "dst" being NULL doesn't seem to be possible at this point this
> patch removes the NULL check.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Agreed.
Acked-by: Masahide NAKAMURA <nakam@linux-ipv6.org>
--
Masahide NAKAMURA
next prev parent reply other threads:[~2007-10-15 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 17:52 [2.6 patch] __inet6_csk_dst_store(): fix check-after-use Adrian Bunk
2007-10-15 2:45 ` Masahide NAKAMURA [this message]
2007-10-15 3:37 ` Noriaki TAKAMIYA
2007-10-15 8:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015113723.00F7.NAKAM@linux-ipv6.org \
--to=nakam@linux-ipv6.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=takamiya@po.ntts.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.