From: David Chinner <dgc@sgi.com>
To: Bhagi rathi <jahnu77@gmail.com>
Cc: David Chinner <dgc@sgi.com>,
Andrew Clayton <andrew@digital-domain.net>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: XFS regression?
Date: Mon, 15 Oct 2007 21:57:45 +1000 [thread overview]
Message-ID: <20071015115745.GK995458@sgi.com> (raw)
In-Reply-To: <cc7060690710150258v327637c3i3c0df4a821d2d056@mail.gmail.com>
On Mon, Oct 15, 2007 at 03:28:34PM +0530, Bhagi rathi wrote:
> Thanks Dave for the response. Thinking futher, why is that xfs_iunpin has
> to mark the inode dirty?
Because the inode has been modified, and instead of sprinkling
mark_inode_dirty_sync() all over the code, we can do it in a single
spot that catches all inode modifications. We don't have to think about
it by doing this - inodes in transactions get marked dirty for free....
> All transactions generally modify one time or other, xfs_ichgtime takes care
> of marking inode as
> dirty.
Sure, but there's plenty of other transactions that don't have such
a convenient hook.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-10-15 11:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 14:27 XFS regression? Andrew Clayton
2007-10-11 1:01 ` David Chinner
2007-10-11 9:05 ` Andrew Clayton
2007-10-11 14:15 ` Andrew Clayton
2007-10-11 21:53 ` David Chinner
2007-10-12 0:26 ` David Chinner
2007-10-12 11:36 ` Andrew Clayton
2007-10-12 13:28 ` Andrew Clayton
2007-10-13 13:35 ` Bhagi rathi
2007-10-14 23:09 ` David Chinner
2007-10-15 9:58 ` Bhagi rathi
2007-10-15 11:57 ` David Chinner [this message]
2007-10-14 23:19 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015115745.GK995458@sgi.com \
--to=dgc@sgi.com \
--cc=andrew@digital-domain.net \
--cc=jahnu77@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.