All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: mb@bu3sch.de, st3@riseup.net, Larry.Finger@lwfinger.net,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [-mm Patch] drivers/net/wireless/b43/main.c: fix an uninitialized variable
Date: Mon, 15 Oct 2007 14:56:44 +0200	[thread overview]
Message-ID: <20071015125644.GB5417@stusta.de> (raw)
In-Reply-To: <20071015113445.GO2444@hacking>

On Mon, Oct 15, 2007 at 07:34:45PM +0800, WANG Cong wrote:
> 
> Fix an uninitialized variable in drivers/net/wireless/b43/main.c::b43_start().
> 
> From: Adrian Bunk <bunk@kernel.org>

A technical remark regarding these two patches:

These are your patches, not mine.

You can note formally or informally that I reported/forwarded these 
issues, but I'm neither in a legal sense the author of these patches nor
am I in a technical sense responsible for their correctness [1], and a 
From: tag is therefore not appropriate.

> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> 
> ---
>  drivers/net/wireless/b43/main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.23-mm1/drivers/net/wireless/b43/main.c
> ===================================================================
> --- linux-2.6.23-mm1.orig/drivers/net/wireless/b43/main.c
> +++ linux-2.6.23-mm1/drivers/net/wireless/b43/main.c
> @@ -3495,7 +3495,7 @@ static int b43_start(struct ieee80211_hw
>  	struct b43_wl *wl = hw_to_b43_wl(hw);
>  	struct b43_wldev *dev = wl->current_dev;
>  	int did_init = 0;
> -	int err;
> +	int err = 0;
>  
>  	mutex_lock(&wl->mutex);

cu
Adrian

[1] they might or might not be correct (I don't know)

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-10-15 12:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-14 17:51 b43{,legacy}_start can return uninitialized value Adrian Bunk
2007-10-15 11:34 ` [-mm Patch] drivers/net/wireless/b43/main.c: fix an uninitialized variable WANG Cong
2007-10-15 12:56   ` Adrian Bunk [this message]
2007-10-15 13:33     ` WANG Cong
2007-10-15 11:59 ` [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value WANG Cong
2007-10-15 15:03   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071015125644.GB5417@stusta.de \
    --to=bunk@kernel.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=st3@riseup.net \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.