From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IhQXi-0005bw-WA for mharc-grub-devel@gnu.org; Mon, 15 Oct 2007 10:03:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IhQXg-0005ad-RR for grub-devel@gnu.org; Mon, 15 Oct 2007 10:03:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IhQXf-0005YS-7c for grub-devel@gnu.org; Mon, 15 Oct 2007 10:03:36 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IhQXf-0005YE-4j for grub-devel@gnu.org; Mon, 15 Oct 2007 10:03:35 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IhQXe-0000HA-GM for grub-devel@gnu.org; Mon, 15 Oct 2007 10:03:34 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IhQXa-000286-A2 for grub-devel@gnu.org; Mon, 15 Oct 2007 16:03:30 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IhQX8-0004Uu-Vr for grub-devel@gnu.org; Mon, 15 Oct 2007 16:03:02 +0200 Date: Mon, 15 Oct 2007 16:03:02 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071015140302.GA17241@thorin> References: <20071007154204.GA8149@thorin> <8a2a06bb0710100801p6741f1b0u60074014479eaf26@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a2a06bb0710100801p6741f1b0u60074014479eaf26@mail.gmail.com> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] bring initial context to a known state X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 14:03:37 -0000 On Wed, Oct 10, 2007 at 05:01:44PM +0200, Marcin Kurek wrote: > Hell[o] > > > When GRUB starts initial_context is in an unknown state. This can lead to > > GRUB detecting bogus variables from it. Attached patch zeroes that struct > > during initialisation to avoid that. > > This change broken command line argument handling for ieee1275. > Arguments are read by grub_machine_init() in this case and zeroing is > done just after that. > > I guess it should be placed before grub_machine_init() to avoid this problem. Uhm.. Marco pointed out that it's in the ELF standard that memory is zeroed before load. So there isn't really a problem, and my issue was just found in an inconsistent situation when playing with LB self-boot. Let's kill this thread. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)